* [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include
@ 2018-12-14 16:40 Jeff Shaw
2018-12-17 15:42 ` Rami Rosen
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Shaw @ 2018-12-14 16:40 UTC (permalink / raw)
To: dev; +Cc: jeffrey.b.shaw
Prior to this patch, the two affected .c files include <dirent.h>
unnecessarily. This commit removes the include lines.
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
lib/librte_eal/common/eal_common_lcore.c | 1 -
lib/librte_eal/common/rte_service.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
index 3167e9d79..1cbac4228 100644
--- a/lib/librte_eal/common/eal_common_lcore.c
+++ b/lib/librte_eal/common/eal_common_lcore.c
@@ -5,7 +5,6 @@
#include <unistd.h>
#include <limits.h>
#include <string.h>
-#include <dirent.h>
#include <rte_errno.h>
#include <rte_log.h>
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 0f3695c4b..03fde97a9 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -7,7 +7,6 @@
#include <inttypes.h>
#include <limits.h>
#include <string.h>
-#include <dirent.h>
#include <rte_compat.h>
#include <rte_service.h>
--
2.14.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include
2018-12-14 16:40 [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include Jeff Shaw
@ 2018-12-17 15:42 ` Rami Rosen
2018-12-17 23:58 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Rami Rosen @ 2018-12-17 15:42 UTC (permalink / raw)
To: Jeff Shaw; +Cc: dev
Reviewed-by: Rami Rosen <ramirose@gmail.com>
On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> Prior to this patch, the two affected .c files include <dirent.h>
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
> lib/librte_eal/common/eal_common_lcore.c | 1 -
> lib/librte_eal/common/rte_service.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
> index 3167e9d79..1cbac4228 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
> @@ -5,7 +5,6 @@
> #include <unistd.h>
> #include <limits.h>
> #include <string.h>
> -#include <dirent.h>
>
> #include <rte_errno.h>
> #include <rte_log.h>
> diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
> index 0f3695c4b..03fde97a9 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -7,7 +7,6 @@
> #include <inttypes.h>
> #include <limits.h>
> #include <string.h>
> -#include <dirent.h>
>
> #include <rte_compat.h>
> #include <rte_service.h>
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include
2018-12-17 15:42 ` Rami Rosen
@ 2018-12-17 23:58 ` Ferruh Yigit
2018-12-19 0:30 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-12-17 23:58 UTC (permalink / raw)
To: Rami Rosen, Jeff Shaw; +Cc: dev
On 12/17/2018 3:42 PM, Rami Rosen wrote:
> On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>>
>> Prior to this patch, the two affected .c files include <dirent.h>
>> unnecessarily. This commit removes the include lines.
>>
>> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include
2018-12-17 23:58 ` Ferruh Yigit
@ 2018-12-19 0:30 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-12-19 0:30 UTC (permalink / raw)
To: Jeff Shaw; +Cc: dev, Ferruh Yigit, Rami Rosen
18/12/2018 00:58, Ferruh Yigit:
> On 12/17/2018 3:42 PM, Rami Rosen wrote:
> > On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
> >>
> >> Prior to this patch, the two affected .c files include <dirent.h>
> >> unnecessarily. This commit removes the include lines.
> >>
> >> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> >
> > Reviewed-by: Rami Rosen <ramirose@gmail.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-19 0:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 16:40 [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include Jeff Shaw
2018-12-17 15:42 ` Rami Rosen
2018-12-17 23:58 ` Ferruh Yigit
2018-12-19 0:30 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).