From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A7E021B8FE for ; Mon, 17 Dec 2018 20:27:18 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C946758E22; Mon, 17 Dec 2018 19:27:17 +0000 (UTC) Received: from localhost (ovpn-116-196.ams2.redhat.com [10.36.116.196]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 514E65C579; Mon, 17 Dec 2018 19:27:12 +0000 (UTC) Date: Mon, 17 Dec 2018 20:27:10 +0100 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, Gavin.Hu@arm.com Message-ID: <20181217192710.kjeor5pgf4lautom@jenstp.localdomain> References: <20181214155916.1142-1-jfreimann@redhat.com> <20181214155916.1142-10-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 17 Dec 2018 19:27:17 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 19:27:19 -0000 On Mon, Dec 17, 2018 at 05:52:08PM +0100, Maxime Coquelin wrote: >I think you meant control queue in the title? > >On 12/14/18 4:59 PM, Jens Freimann wrote: >>Until we have support for ctrl virtqueues let's disable it and >>fail device initalization if specified as a parameter. >> >>Signed-off-by: Jens Freimann >>--- >> drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >>diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c >>index 697ba4ae8..14597eb73 100644 >>--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c >>+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c >>@@ -467,10 +467,16 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, >> if (!in_order) >> dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER); >>- if (packed_vq) >>+ if (packed_vq) { >>+ if (cq) { >>+ PMD_INIT_LOG(ERR, "control vq not supported with " > >Maybe change to "not supported *yet*". sure, no problem. regards, Jens