From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id 291221B885 for ; Wed, 19 Dec 2018 13:43:15 +0100 (CET) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wBJCh1j0023248; Wed, 19 Dec 2018 04:43:02 -0800 Date: Wed, 19 Dec 2018 18:11:22 +0530 From: Rahul Lakkireddy To: Ferruh Yigit Cc: "dev@dpdk.org" , Satish Rangarajan , Indranil Choudhury Message-ID: <20181219124121.GB11932@chelsio.com> References: <1544713333-32239-1-git-send-email-rahul.lakkireddy@chelsio.com> <1544713333-32239-4-git-send-email-rahul.lakkireddy@chelsio.com> <87545ce6-04f1-d29c-5bd6-6b5211a85fc6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87545ce6-04f1-d29c-5bd6-6b5211a85fc6@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 3/4] net/cxgbe: only redefine symbols when not available for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 12:43:16 -0000 On Tuesday, December 12/18/18, 2018 at 23:56:22 +0530, Ferruh Yigit wrote: > On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote: > > Redefine symbols only when they are not available for Windows > > > > Again "for Windows" is very vague, can you please add more context? > These patches are a pre-requisite to enable compilation for CXGBE PMD for Windows OS. It currently uses Intel C++ compiler [1]. Our plan is to integrate these compilation fixes to dpdk-next-net and then ask for a pull request to pull these to dpdk-draft-windows tree [2]. [1] https://software.intel.com/en-us/parallel-studio-xe [2] http://git.dpdk.org/draft/dpdk-draft-windows/ This patch fixes following issues in Windows build: # cxgbe_compat.h(154): warning #47: incompatible redefinition of macro "min" #define min(a, b) RTE_MIN(a, b) ^ # cxgbe_compat.h(158): warning #47: incompatible redefinition of macro "max" #define max(a, b) RTE_MAX(a, b) ^ # t4_hw.c(249): warning #266: function "htobe64" declared implicitly *rpl++ = htobe64(t4_read_reg64(adap, mbox_addr)); ^ # t4_hw.c(338): warning #266: function "bzero" declared implicitly bzero(p, 0, size); ^ # t4_hw.c(5337): warning #266: function "htonl" declared implicitly rvc.op_to_viid = htonl(V_FW_CMD_OP(FW_RSS_VI_CONFIG_CMD) | ^ # t4_hw.c(5344): warning #266: function "ntohl" declared implicitly p->rss_mode = ntohl(rvc.u.basicvirtual.defaultq_to_udpen); ^ # t4vf_hw.ct4vf_hw.c(47): warning #266: function "htobe64" declared implicitly *rpl++ = htobe64(t4_read_reg64(adap, mbox_addr)); ^ # sge.c(361): error : expected an expression struct sge_eth_rxq *rxq = container_of(q, struct sge_eth_rxq, fl); ^ # sge.c(465): warning #266: function "ntohs" declared implicitly int hw_cidx = ntohs(q->stat->cidx); ^ # sge.c(1918): warning #266: function "htons" declared implicitly htons(V_FW_IQ_CMD_IQPCIECH(pciechan) | ^ # sge.c(1350): error : identifier "caddr_t" is undefined static void inline_tx_mbuf(const struct sge_txq *q, caddr_t from, caddr_t *to, ^ Thanks, Rahul