Re: [dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for Windows

[Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>]

On Wednesday, December 12/19/18, 2018 at 19:15:39 +0530, Ferruh Yigit wrote:
> On 12/19/2018 12:39 PM, Rahul Lakkireddy wrote:
> > On Tuesday, December 12/18/18, 2018 at 23:55:26 +0530, Ferruh Yigit wrote:
> >> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> >>> Replace "args..." with "fmt, ..." and directly use __VA_ARGS__.
> >>
> >> What do you mean exactly by "for Windows"? Which compiler? Is there a specific C
> >> standard version you target? What is the issue with existing macros?
> >>
> >> Since we don't have a Windows support in DPDK, yet, it is not clear what you are
> >> targeting.
> >>
> > 
> > These patches are a pre-requisite to enable compilation for CXGBE PMD for
> > Windows OS. It currently uses Intel C++ compiler [1]. Our plan is to
> > integrate these compilation fixes to dpdk-next-net and then ask for a
> > pull request to pull these to dpdk-draft-windows tree [2].
> 
> I think that is OK as long as we don't break the existing platforms, which is
> the case already. I am asking from documentation / keeping record point of view.
> 
> Would you mind sending a new version of the patchset, with more detailed commit
> logs, target compiler and its version, target Windows OS and dependencies if
> any, the log of the error the patch fixes (like below ones) ?
> 

Sure, will update the commit messages with above information and send a v2.

Thanks,
Rahul

> > 
> > These existing macros result in following errors in Windows build:
> > 
> > # cxgbe_compat.h(28): error : expected a ")"
> >     #define dev_printf(level, fmt, args...) \
> >                                        ^
> > 
> > # cxgbe_compat.h(31): error : expected a ")"
> >     #define dev_err(x, args...) dev_printf(ERR, args)
> > 
> > [...]
> > 
> > [1] https://software.intel.com/en-us/parallel-studio-xe
> > [2] http://git.dpdk.org/draft/dpdk-draft-windows/
> > 
> > Thanks,
> > Rahul
> > 
>