From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id 50D0C1B5A8
 for <dev@dpdk.org>; Wed, 19 Dec 2018 15:13:21 +0100 (CET)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wBJEDHLj023707;
 Wed, 19 Dec 2018 06:13:18 -0800
Date: Wed, 19 Dec 2018 19:41:39 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Satish Rangarajan <satishr@chelsio.com>,
 Indranil Choudhury <indranil@chelsio.com>
Message-ID: <20181219141138.GA12075@chelsio.com>
References: <1544713333-32239-1-git-send-email-rahul.lakkireddy@chelsio.com>
 <1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com>
 <7aca347c-b551-f092-ba3b-e31e83eeed26@intel.com>
 <20181219123925.GA11932@chelsio.com>
 <e5fc5853-e7ad-b990-e540-e35c26023f90@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e5fc5853-e7ad-b990-e540-e35c26023f90@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs
 for Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 14:13:21 -0000

On Wednesday, December 12/19/18, 2018 at 19:15:39 +0530, Ferruh Yigit wrote:
> On 12/19/2018 12:39 PM, Rahul Lakkireddy wrote:
> > On Tuesday, December 12/18/18, 2018 at 23:55:26 +0530, Ferruh Yigit wrote:
> >> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> >>> Replace "args..." with "fmt, ..." and directly use __VA_ARGS__.
> >>
> >> What do you mean exactly by "for Windows"? Which compiler? Is there a specific C
> >> standard version you target? What is the issue with existing macros?
> >>
> >> Since we don't have a Windows support in DPDK, yet, it is not clear what you are
> >> targeting.
> >>
> > 
> > These patches are a pre-requisite to enable compilation for CXGBE PMD for
> > Windows OS. It currently uses Intel C++ compiler [1]. Our plan is to
> > integrate these compilation fixes to dpdk-next-net and then ask for a
> > pull request to pull these to dpdk-draft-windows tree [2].
> 
> I think that is OK as long as we don't break the existing platforms, which is
> the case already. I am asking from documentation / keeping record point of view.
> 
> Would you mind sending a new version of the patchset, with more detailed commit
> logs, target compiler and its version, target Windows OS and dependencies if
> any, the log of the error the patch fixes (like below ones) ?
> 

Sure, will update the commit messages with above information and send a v2.

Thanks,
Rahul

> > 
> > These existing macros result in following errors in Windows build:
> > 
> > # cxgbe_compat.h(28): error : expected a ")"
> >     #define dev_printf(level, fmt, args...) \
> >                                        ^
> > 
> > # cxgbe_compat.h(31): error : expected a ")"
> >     #define dev_err(x, args...) dev_printf(ERR, args)
> > 
> > [...]
> > 
> > [1] https://software.intel.com/en-us/parallel-studio-xe
> > [2] http://git.dpdk.org/draft/dpdk-draft-windows/
> > 
> > Thanks,
> > Rahul
> > 
>