From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 47F2B5A44
 for <dev@dpdk.org>; Thu, 27 Dec 2018 11:13:53 +0100 (CET)
Received: from lfbn-1-5979-29.w90-110.abo.wanadoo.fr ([90.110.18.29]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1gcShS-0001D1-OM; Thu, 27 Dec 2018 11:15:36 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Thu, 27 Dec 2018 11:13:49 +0100
Date: Thu, 27 Dec 2018 11:13:49 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20181227101349.f4i64ug3elogsldp@platinum>
References: <1544110714-4514-2-git-send-email-konstantin.ananyev@intel.com>
 <1544804589-10338-3-git-send-email-konstantin.ananyev@intel.com>
 <341196b4-918d-a811-da1c-4ec497a3d0b4@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <341196b4-918d-a811-da1c-4ec497a3d0b4@nxp.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v4 03/10] net: add ESP trailer structure
 definition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Dec 2018 10:13:53 -0000

Hi,

On Wed, Dec 19, 2018 at 09:32:09AM +0000, Akhil Goyal wrote:
> 
> 
> On 12/14/2018 9:53 PM, Konstantin Ananyev wrote:
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > Acked-by: Declan Doherty <declan.doherty@intel.com>
> > ---
> >   lib/librte_net/rte_esp.h | 10 +++++++++-
> >   1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h
> > index f77ec2eb2..8e1b3d2dd 100644
> > --- a/lib/librte_net/rte_esp.h
> > +++ b/lib/librte_net/rte_esp.h
> > @@ -11,7 +11,7 @@
> >    * ESP-related defines
> >    */
> >   
> > -#include <stdint.h>
> > +#include <rte_byteorder.h>
> >   
> >   #ifdef __cplusplus
> >   extern "C" {
> > @@ -25,6 +25,14 @@ struct esp_hdr {
> >   	rte_be32_t seq;  /**< packet sequence number */
> >   } __attribute__((__packed__));
> >   
> > +/**
> > + * ESP Trailer
> > + */
> > +struct esp_tail {
> > +	uint8_t pad_len;     /**< number of pad bytes (0-255) */
> > +	uint8_t next_proto;  /**< IPv4 or IPv6 or next layer header */
> > +} __attribute__((__packed__));
> > +
> >   #ifdef __cplusplus
> >   }
> >   #endif
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Is there a reason to pack the structure? I think it has no impact since
it is only composed of uint8_t, so it can be removed.

Thanks,
Olivier