From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by dpdk.org (Postfix) with ESMTP id 1A31D1B4BA for ; Fri, 4 Jan 2019 20:32:13 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id 64so18731006pfr.9 for ; Fri, 04 Jan 2019 11:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k9Vxa75VG1aF6SO2zK4/Umn5ULIRFwDRPVfDPhino9Y=; b=eb3kOKP7RDgyuQ7AdsRvo0jWbQ6srfVOft11MJJzzUel//gmkS5IzRUsN3B3AkhZ2q mdHLezhEJYHT+q9FErKDQHNzLndipbjj7lULFh1TBuY0V38kKEETHKk1uQKfWzM4AduZ t14zSfBKjlLCw+y4IgL+3wU4IN+1uZc28J6OZ2NXMekMdwJ0JwGkJOPAbe1ktwaaWuQa xRYvQN62SVYEqWGT/y30utv13a50mzekw0HnQ4H1ZvcZv4HvN0JTn4ywNMlNbosQS64X 2oH0guG5fg80+hVVMcy7IXNkOK5m2ksax1xoYDwE2ZA5F4zjwqnHvPS4k/Tx9cE8H1cX /jSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k9Vxa75VG1aF6SO2zK4/Umn5ULIRFwDRPVfDPhino9Y=; b=pce2a3goMrh29uhveiTOsdsSgaKVYmIPWtPiwhURFz9J6AIupqP/4g0rWYZdHKgYQn gSPwWgN6LW8e9m7vEwCkvw8hYu2rreWlu9hVigKRn6WgNuWdrzZja4hFEdEqOSoaOKyK 8mgX+fasdJ3O04HjeFVtbabu0SIpTJ93GxCdu1rn4yWOyThIGBF2xbKH62erH5SAItD1 Kt+xTEy019D3q0VMtzVgZX+MK7iZcaend9Beeg12O/vYo8lnvZ5BSbNkdZjRmVWB2UqY xi3l8Edc+VauXBoxPIC3qrtChKybPbxj5RU8y/V+LO9KwpOZSM4lLg9SiBC9XVMx//4S arNQ== X-Gm-Message-State: AJcUukd7t9tvy/WKcRvFpXseJaG5u/8LiG5U4LklhD+Psb9RUZZXqglm wVuaT5osjSDIPJl8MrznMOTFzA== X-Google-Smtp-Source: ALg8bN5xwIRwr1D6J+mqDVf0cgQqH05nenXkiao1tQ2n5uJL+BCcHI0ynJYW+OwgWKEBugkduuLRaA== X-Received: by 2002:a63:f30d:: with SMTP id l13mr21866264pgh.399.1546630332124; Fri, 04 Jan 2019 11:32:12 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q7sm75382521pgp.40.2019.01.04.11.32.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 11:32:12 -0800 (PST) Date: Fri, 4 Jan 2019 11:32:05 -0800 From: Stephen Hemminger To: Jakub Grajciar Cc: Message-ID: <20190104113205.5b76e3aa@hermes.lan> In-Reply-To: <20181213133051.18779-1-jgrajcia@cisco.com> References: <20181213133051.18779-1-jgrajcia@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v3] /net: memory interface (memif) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 19:32:13 -0000 On Thu, 13 Dec 2018 14:30:51 +0100 Jakub Grajciar wrote: > + role = MEMIF_ROLE_SLAVE; > + flags = 0; > + id = 0; > + buffer_size = 2048; > + log2_ring_size = 10; > + nrxq = 1; > + ntxq = 1; > + socket_filename = ETH_MEMIF_DEFAULT_SOCKET_FILENAME; > + secret = NULL; > + eth_addr = NULL; Minor nit, since you initialize some of the values when declaring them. Why not move all these initializations up to where the declaration is. Just makes everything more compact. > + /* create interface */ > + ret = > + memif_create(vdev, role, id, flags, socket_filename, log2_ring_size, > + nrxq, ntxq, buffer_size, secret, eth_addr); > + Another nit, why split the line like this? Instead of: ret = memif_create(vdev, role, id, flags, socket_filename, log2_ring_size, nrxq, ntxq, buffer_size, secret, eth_addr);