From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 870261B4C8 for ; Wed, 9 Jan 2019 19:20:22 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id z11so3668359pgu.0 for ; Wed, 09 Jan 2019 10:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kCcgKKJhf//CYqMxooHODxHCySPeWCh9qph4Ml3JNbs=; b=bkNQLUWu+iFEiMBskgaj8AJXDwFS/N3rcVOQls8MNSi56G2FRKktrsRY1d987m+urg Z3kmjv4iG37e/j7CDX3TMdbfYpXfuFH1YDypwEuiSC7vYJ1+SnRf0tN+THT9iEooqkQ+ pVLIFD1LdF/UnfJoy7M86BuX4zUMLTmpD4KNLQ+tIYPZ//p4jTbDalyD/+L71aA7dx6l L+2ELGZPd0R0OHAlorwsVxMnosFP8xVDVngEz/d5UtY2J+XKJ/aVrGDPTI1ppwt99PjT QksWlHDjo6DA/kRJ3oNtlLPD42De69Xo1BtS9SMJvW/QktJl6yQunPE9xMzSspnBFZo4 vB/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kCcgKKJhf//CYqMxooHODxHCySPeWCh9qph4Ml3JNbs=; b=ptvC2qtOB1GiNgU57ZpflACAnTX3NDHd5UqeuLlrYF0xEu331u1rAPqSiTIiYdlhcG uRiKyJseq9pMRx7UVoCYolt8xeVN1yno3vJP0e1BCASZMh3H/ZNUG6TjUypxon2573B7 YXCuP6LL5BTfnSkdMMtjmL0ZHZ9D+4xYHGgVpCASr+3YB1LOix8UXAF3+IA607NJBOYm 2q+4uNBOe+PHEenS5YOwfPUh6EnUImYmKUsmWDWSU/qugyrWvFmQkp6EHy2JcHH0JA/e 8WhbBftjFAVqnIyurE5fYzIzC4uBLdxD1TlubPeGXwEjHcTRuaPCRLvXbLMvHvtpqpY3 6zfw== X-Gm-Message-State: AJcUukf6ZuDqnyqkKUTJ6nBeelc67DFDPALbq+UHUjJAcMLOCLCXzZG/ vgQXgW3BtLOBcnglp5upWg+IHQ== X-Google-Smtp-Source: ALg8bN7L00YiOf8SPCe5Tn4p0c49dyFFjFe2kB+DeW3xxlWYqKitvjIOH3fA1SZOGhoKY1pA7l5tmw== X-Received: by 2002:a63:4002:: with SMTP id n2mr6301241pga.137.1547058021579; Wed, 09 Jan 2019 10:20:21 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m20sm92820723pgb.56.2019.01.09.10.20.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Jan 2019 10:20:21 -0800 (PST) Date: Wed, 9 Jan 2019 10:20:14 -0800 From: Stephen Hemminger To: Jiayu Hu Cc: dev@dpdk.org, konstantin.ananyev@intel.com, mb@smartsharesystems.com, thomas@monjalon.net, vipin.varghese@intel.com, stable@dpdk.org Message-ID: <20190109102014.41c685b5@hermes.lan> In-Reply-To: <1547021995-14231-1-git-send-email-jiayu.hu@intel.com> References: <1547002811-6989-1-git-send-email-jiayu.hu@intel.com> <1547021995-14231-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 18:20:23 -0000 O be merged. > + > +GRO Library Limitations > +----------------------- > + > +- GRO library uses the values of MBUF->l2_len/l3_len/l4_len/ > + outer_l2_len/outer_l3_len to get protocol headers for the > + input packet, rather than parsing the packet header. Therefore, > + before call GRO APIs to merge packets, user applications > + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len > + to the same values as the protocol headers of the packet. > + Since these length values are critical to other functionality why not require all poll mode drivers to set them. Many poll mode drivers call rte_net_get_ptype() on the received mbuf and it already handles setting this. One could argue that GRO should just log and die if it gets malformed data.