From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id 467891B96B for <dev@dpdk.org>; Fri, 11 Jan 2019 01:12:06 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id q1so6068516pfi.5 for <dev@dpdk.org>; Thu, 10 Jan 2019 16:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FaZqzu7W//97aifVK9R0/u987uHQlBwjYCAcRW+FXRs=; b=CCsgaN7Ai5yb65B/7ChqHsz87Yj6Hl6h3MM1VtTnRzFk8iIXmRir2MUWKI4tL75ILb x/+HLDIFP5LqXcDOXpGntDTGDhT6k0IplP6g8Wz0DVtW0fA3KF6SfCks6RcIMdX60dBQ 8pbdCkNuaB0rcCgff+QJmHj6rMcrxME+7ST50WHtldS/eEya1DmqFAO6kpHUJMKz24Pv 9GAY6eDBj827qeCgLQPrv0HNvTGt+PWrTQIgv2/RtbSgmy8ZLEB94YAgS1naJcjbqSls c2e4mjVjg88kr13Nkf7TCs5IVXxXQciLhUwsVpnjN8FqBXxcjgQSCjlGrBZx9B5YbDnW oq8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FaZqzu7W//97aifVK9R0/u987uHQlBwjYCAcRW+FXRs=; b=uLm2Afqitii4LNdcEaCCN+utwse6TcVhA2hE3MrHpu9Zrs1o7ZyAabUXhJ1osjuf+D EAb08ZDVYMzTxERbHiG5FcoH/x/Q9onNRx58lcg1cnVq5ibH1E7HvRdUem4UqQVAYN7B pZDTOSFbNqDjJki/loBfaTKY8GcEqjsWBq37scZIsmkpTkOHJh+iw/uuspd4LRq5+afu oocqGu6nrKOSQhiAOCG8JN0Z8pVEi9ZLnLONjD4/RdDwkVii1V/ZkwQE0IzTFv8yHUpc W2yi7b+WA90PT7WGur56gpTHfTah+bZ/BiyH84AYIUfbdMef5BLL6zb9g7zBl3xPJrCF UIjg== X-Gm-Message-State: AJcUukdPx/97mESCt2I/NQb479A6hkOfkXIh557IDRLjBibK833B+Lph He/9zo60LrU+YsDlBDqVvs9WKA== X-Google-Smtp-Source: ALg8bN5Gsty/sH86l0vOqB+YSGlIc+Hl8Bf1BQGM9zRKJmQaCguvt7aPGDhY7YzCPckTzX6dLNeMdg== X-Received: by 2002:a62:2781:: with SMTP id n123mr12438819pfn.138.1547165525338; Thu, 10 Jan 2019 16:12:05 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p24sm126093806pfk.155.2019.01.10.16.12.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 16:12:05 -0800 (PST) Date: Thu, 10 Jan 2019 16:11:58 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Rami Rosen <roszenrami@gmail.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>, dev@dpdk.org, olivier.matz@6wind.com, arybchenko@solarflare.com, ferruh.yigit@intel.com Message-ID: <20190110161158.0177a203@hermes.lan> In-Reply-To: <CAKoUAr=xAnUY4xjDD2wv5dEmonEHHknK_rbO3DJeiMdCKiSfgQ@mail.gmail.com> References: <98CBD80474FA8B44BF855DF32C47DC35B425B1@smartserver.smartshare.dk> <CAKoUArmoWha8f=bTcvXWfSBH26KAvxqRqmWSHx4RCA6PatA5RA@mail.gmail.com> <98CBD80474FA8B44BF855DF32C47DC35B425B8@smartserver.smartshare.dk> <3446539.r5cUhzCBca@xps> <CAKoUAr=xAnUY4xjDD2wv5dEmonEHHknK_rbO3DJeiMdCKiSfgQ@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] function to parse packet headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 11 Jan 2019 00:12:06 -0000 On Thu, 10 Jan 2019 03:03:24 +0200 Rami Rosen <roszenrami@gmail.com> wrote: > Hi, Morten, > > > And regarding avoiding code duplicity, I'm pursuing Olivier about merging > packet header validation into rte_net_get_ptype() instead of writing a > separate function. > > > This seems also a good alternative. > +1 > > Regards, > Rami Rosen > +1 All drivers that don't have hardware support for getting l2/l3 and ptype information should be calling rte_net_get_ptype() already.