From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D97841BC77 for ; Fri, 11 Jan 2019 15:30:26 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 06:30:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="311029794" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by fmsmga005.fm.intel.com with SMTP; 11 Jan 2019 06:30:23 -0800 Received: by (sSMTP sendmail emulation); Fri, 11 Jan 2019 14:30:23 +0000 Date: Fri, 11 Jan 2019 14:30:23 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190111123809.8789-1-bluca@debian.org> <20190111123809.8789-3-bluca@debian.org> <20190111142700.GB15912@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190111142700.GB15912@bricha3-MOBL.ger.corp.intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 14:30:27 -0000 On Fri, Jan 11, 2019 at 02:27:01PM +0000, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 12:38:09PM +0000, Luca Boccassi wrote: > > Move libbsd inclusion to librte_eal, so that all other libraries and > > PMDs will inherit it, and librte_cmdline which is built before > > librte_eal. > > Bump Meson dependency to 0.47.1, to avoid bug where the linker flag of > > the dependency gets replicated again and again. > > > > Signed-off-by: Luca Boccassi > > --- > > v2: bump meson minimum version to 0.47.1 to avoid meson bug, and move > > libbsd dependency to eal and cmdline > > > > config/meson.build | 10 +++++----- > > lib/librte_cmdline/meson.build | 4 ++++ > > lib/librte_eal/meson.build | 3 +++ > > meson.build | 2 +- > > 4 files changed, 13 insertions(+), 6 deletions(-) > > > There are some meson version checks in the code that can be removed as > part of this change: > > $ git grep meson.version > drivers/meson.build: if meson.version().version_compare('>=0.47') > kernel/linux/meson.build: if meson.version().version_compare('>=0.44') > kernel/linux/meson.build: if meson.version().version_compare('>=0.44') > meson.build: meson_version: '>= 0.41' > meson.build:if meson.version().version_compare('>=0.47') > Thinking on this more, I think the version bump to 0.47 should be done in a separate standalone patch at the start of this set. Then the other patches can be based on that. /Bruce