From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com
[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1B38C271
for <dev@dpdk.org>; Wed, 16 Jan 2019 02:38:25 +0100 (CET)
Received: by mail-pl1-f196.google.com with SMTP id p8so2177174plo.2
for <dev@dpdk.org>; Tue, 15 Jan 2019 17:38:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=UVGN0+jhRidurjQucxVE94zolaK3pLwJQAnDlDUB2x4=;
b=Qb1kwkJh8UGZ+6klf2o6SqIwxJD6oCb1qIlEYwJzmq4/TWxQzsHR8knNR++gyAZuCt
NLVYMclUXU9oadZLdIxLwWG4FWW7WpeoDdwaZfnwAVCU2aeKYLOr5e9SuAw086ECGIRw
Wbba5ukiLCVSMIwX/k07t4qV6FtIQTB+EVkZwcK9BI9Pa8xf+k5UkJAu/OW/pDLsX6gf
CULHUQa0NCNV7fB7V5r2gl2g4blpg3hopB7ubIWy0fTHzTVeF4f3NtDhW8UTKdN62vsl
rIGfVk5xxq29uot1jCHtxo6WB3fsgUf0SHv/Oh7zVC2p9s9nxz9n1F5oIkIL3n3Rz2sk
Xeqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=UVGN0+jhRidurjQucxVE94zolaK3pLwJQAnDlDUB2x4=;
b=tU36iANBFKqkD7vKGA+7PXBW6OBlkdxBbFAuRU9w2pkEsd9OORtTknCLKllq/8qo/y
1j6eeA6BdEpFfHvwCUlrkOu22P2uzILVI3j7j+6WEjhQAr3srw8HCXkgSuI77cYfjaK+
tzVmquxVQ4+N/Bj0IFld1kql+Q1nG6ncjTaym1VMucCXIqPCAZ0jgwLmmp2w9h0YLLnL
oad17ASc6uGf/7lF9lK7omwnyeTa9vBVDX/09pi28Oh/lEjR21SlvdgStJ9fHQn6sB+V
fMod7uwjf3iGFRCDv18wqbzdtXIHM45rJLQJEg8/Zu/40pMzcNY/K0BmoQeuxJblgB8w
uVEQ==
X-Gm-Message-State: AJcUukfHw1uMXRBDptBySPVqK3MGKbugwkshWn6NK3mDQAnk8eIJe7RW
YMxzF7Ja5LH9eKbpX4zEU7/Zhw==
X-Google-Smtp-Source: ALg8bN5mdycM2yxFXb2PXFcpS7VgAobG8u0C+uVkETcqMJUJA+fGVoms67g4Z65PZp9J8B+Sa/YR0Q==
X-Received: by 2002:a17:902:2c03:: with SMTP id
m3mr7365314plb.125.1547602704644;
Tue, 15 Jan 2019 17:38:24 -0800 (PST)
Received: from shemminger-XPS-13-9360 ([167.220.61.105])
by smtp.gmail.com with ESMTPSA id g28sm6255767pfd.100.2019.01.15.17.38.24
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 15 Jan 2019 17:38:24 -0800 (PST)
Date: Tue, 15 Jan 2019 17:38:22 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <20190115173822.25a4a979@shemminger-XPS-13-9360>
In-Reply-To: <20190116003452.37403-1-xiaolong.ye@intel.com>
References: <20190115154626.34516-1-xiaolong.ye@intel.com>
<20190116003452.37403-1-xiaolong.ye@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2019 01:38:26 -0000
On Wed, 16 Jan 2019 08:34:52 +0800
Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
> remove it to avoid misleading.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> kernel/linux/igb_uio/igb_uio.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
> index 3cf394bdf..d6ac51e79 100644
> --- a/kernel/linux/igb_uio/igb_uio.c
> +++ b/kernel/linux/igb_uio/igb_uio.c
> @@ -185,10 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
> return 0;
> }
>
> -/**
> - * This is interrupt handler which will check if the interrupt is for the right device.
> - * If yes, disable it here and will be enable later.
> - */
> static irqreturn_t
> igbuio_pci_irqhandler(int irq, void *dev_id)
> {
The comment is partially correct; if you look at the legacy case.
Maybe better to move the comment to pci_check_and_mask_intx in compat.h?
I see there is another incorrect comment there.