From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8B9BC239; Thu, 17 Jan 2019 13:19:21 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 04:19:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="267856763" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga004.jf.intel.com with SMTP; 17 Jan 2019 04:19:17 -0800 Received: by (sSMTP sendmail emulation); Thu, 17 Jan 2019 12:19:17 +0000 Date: Thu, 17 Jan 2019 12:19:16 +0000 From: Bruce Richardson To: Hari Kumar Vemula Cc: dev@dpdk.org, david.marchand@redhat.com, reshma.pattan@intel.com, ferruh.yigit@intel.com, jananeex.m.parthasarathy@intel.com, stable@dpdk.org Message-ID: <20190117121916.GA319108@bricha3-MOBL.ger.corp.intel.com> References: <1547216106-13680-1-git-send-email-hari.kumarx.vemula@intel.com> <1547727192-25126-1-git-send-email-hari.kumarx.vemula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547727192-25126-1-git-send-email-hari.kumarx.vemula@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v6] eal: fix core number validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 12:19:22 -0000 On Thu, Jan 17, 2019 at 12:13:12PM +0000, Hari Kumar Vemula wrote: > When incorrect core value or range provided, > as part of -l command line option, a crash occurs. > > Added valid range checks to fix the crash. > > Added ut check for negative core values. > Added unit test case for invalid core number range. > > Fixes: d888cb8b9613 ("eal: add core list input format") > Cc: stable@dpdk.org > > Signed-off-by: Hari Kumar Vemula > Reviewed-by: David Marchand > -- > v6: Changed testcase order > v5: Corrected unit test case for -l option > v4: Used RTE_MAX_LCORE for max core check > v3: Added unit test cases for invalid core number range > v2: Replace strtoul with strtol > Modified log message > --- > lib/librte_eal/common/eal_common_options.c | 9 +++- > test/test/test_eal_flags.c | 61 ++++++++++++++-------- > 2 files changed, 45 insertions(+), 25 deletions(-) > Is this patch related to, or does it fix Bugzilla #19? https://bugs.dpdk.org/show_bug.cgi?id=19 /Bruce