From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E814620BD for ; Tue, 29 Jan 2019 16:30:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 07:30:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,537,1539673200"; d="scan'208";a="315849550" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2019 07:30:53 -0800 From: Ferruh Yigit To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org, Qi Zhang Date: Tue, 29 Jan 2019 15:30:52 +0000 Message-Id: <20190129153052.38634-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.17.2 Subject: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 15:30:57 -0000 Fixes line commit id length defined as 12 in fixline alias: fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' Check if the Fixes line commit id length matches the defined value. Signed-off-by: Ferruh Yigit --- Cc: Qi Zhang --- devtools/check-git-log.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index d39064f9d..f4d6c1fba 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -177,6 +177,11 @@ bad=$(for fixtag in $fixtags ; do done | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong 'Fixes' reference:\n$bad\n" +bad=$(for fixtag in $fixtags ; do + echo $fixtag | awk '{print $2}' | awk 'length != 12 {print}' +done) +[ -z "$bad" ] || printf "Wrong 'Fixes' syntax:\n$bad\n" + # check Cc: stable@dpdk.org for fixes bad=$(for fix in $stablefixes ; do git log --format='%b' -1 $fix | grep -qi '^Cc: *stable@dpdk.org' || -- 2.17.2