From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BF4FD1DBC for ; Wed, 30 Jan 2019 12:24:40 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 03:24:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="314834162" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by fmsmga006.fm.intel.com with SMTP; 30 Jan 2019 03:24:37 -0800 Received: by (sSMTP sendmail emulation); Wed, 30 Jan 2019 11:24:36 +0000 Date: Wed, 30 Jan 2019 11:24:36 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: David Marchand , Thomas Monjalon , dev@dpdk.org, Qi Zhang Message-ID: <20190130112436.GA157424@bricha3-MOBL.ger.corp.intel.com> References: <20190129153052.38634-1-ferruh.yigit@intel.com> <6dfa0d84-3734-51be-a4a2-298c0f1b9b7c@intel.com> <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 11:24:41 -0000 On Wed, Jan 30, 2019 at 11:17:00AM +0000, Ferruh Yigit wrote: > On 1/30/2019 9:58 AM, David Marchand wrote: > > On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > > > >> On 1/29/2019 5:34 PM, David Marchand wrote: > >>> On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit > >> wrote: > >>> > >>>> Fixes line commit id length defined as 12 in fixline alias: > >>>> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > >>>> > >>>> Check if the Fixes line commit id length matches the defined value. > >>>> > >>> > >>> Can't git decide to report a longer string in case of collisions of > >>> abbreviated id ? > >>> > >>> Tried this for 2 characters, and git forcefully reported 5 chars: > >>> $ git log -1 --abbrev=2 origin/master --format='Fixes: %h (\"%s\")' > >>> Fixes: a2f9c (\"version: 19.02-rc4\") > >>> > >>> I did not find any collisions with 12 characters abbreviated commitid, > >> but > >>> I am not sure enforcing the check on exactly 12 characters is a good idea > >>> in the long run. > >> > >> Yes git can report a longer string in case of collisions, but I don't > >> expect to > >> have one with 12 characters. > >> > >> This is mainly for some cases either people use full 40 chars or small > >> ones. > >> > >> Indeed in background I am (and most probably Thomas too) fixing them while > >> merging, I thought it is better idea to integrate that into script so that > >> developers can be aware of the syntax issue and fix it before sending. > >> > > > > I can understand you want to avoid such edits yes, and so this patch. > > > > However, I think we can do one more thing. > > The contributing guide does indicate you are supposed to run both > > checkpatches.sh and check-git-log.sh. > > I am pretty sure I missed this second step in the past.. > > > > How about calling check-git-log.sh from checkpatches.sh ? > > check-git-log.sh does not support patch files as input, so it would need > > support for it. > > That sounds good idea to have single script to run. > +1 to this