From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 00EA21B2B3 for ; Wed, 30 Jan 2019 12:32:03 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 03:32:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="314835475" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by fmsmga006.fm.intel.com with SMTP; 30 Jan 2019 03:32:00 -0800 Received: by (sSMTP sendmail emulation); Wed, 30 Jan 2019 11:31:59 +0000 Date: Wed, 30 Jan 2019 11:31:59 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Ferruh Yigit , David Marchand , dev@dpdk.org, Qi Zhang Message-ID: <20190130113159.GC157424@bricha3-MOBL.ger.corp.intel.com> References: <20190129153052.38634-1-ferruh.yigit@intel.com> <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com> <6481538.UeMWjqPEGc@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6481538.UeMWjqPEGc@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 11:32:04 -0000 On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > 30/01/2019 12:17, Ferruh Yigit: > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > The contributing guide does indicate you are supposed to run both > > > checkpatches.sh and check-git-log.sh. > > > I am pretty sure I missed this second step in the past.. > > > > > > How about calling check-git-log.sh from checkpatches.sh ? > > > check-git-log.sh does not support patch files as input, so it would need > > > support for it. > > > > That sounds good idea to have single script to run. > > It will never be only one script to run. > There are more scripts in devtools and I plan to add more. > Some checks can be done only once for a group of commits, > and will be really too slow if run for each patch when merging a branch. > > About check-git-log, some tests cannot be possible outside of a git tree. > Do you want to run it when checkpatches is run on git tree? > Wouldn't it be confusing? > Possibly, but we can print out a warning when not run, saying "check-git-log skipped because we are not running on git tree". I think the benefit of having all checks done by one script is greater than the downside of a little confusion. /Bruce