From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2F9F91B4E9 for ; Fri, 1 Feb 2019 17:48:23 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5735FC07046F; Fri, 1 Feb 2019 16:48:22 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8931C608DA; Fri, 1 Feb 2019 16:48:21 +0000 (UTC) From: Michael Santana To: dev@dpdk.org Cc: Aaron Conole , Bruce Richardson , Honnappa Nagarahalli , Thomas Monjalon Date: Fri, 1 Feb 2019 11:48:13 -0500 Message-Id: <20190201164814.11185-2-msantana@redhat.com> In-Reply-To: <20190201164814.11185-1-msantana@redhat.com> References: <20190130221602.13866-1-msantana@redhat.com> <20190201164814.11185-1-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 01 Feb 2019 16:48:22 +0000 (UTC) Subject: [dpdk-dev] [PATCH v3 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 16:48:23 -0000 From: Aaron Conole The vhost_scsi example code is set to build, even if the requisite header file virtio_scsi.h isn't available. This happens on some Ubuntu systems when some versions of the libc-dev package aren't available. Check whether the virtio_scsi.h file exists, and if not, set the build flag to false. Acked-by: Bruce Richardson Signed-off-by: Aaron Conole --- v3: Removed an already-defined variable examples/vhost_scsi/meson.build | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/vhost_scsi/meson.build b/examples/vhost_scsi/meson.build index 2303bcaed..ca1248023 100644 --- a/examples/vhost_scsi/meson.build +++ b/examples/vhost_scsi/meson.build @@ -9,6 +9,11 @@ if host_machine.system() != 'linux' build = false endif + +if not cc.has_header('virtio_scsi.h') + build = false +endif + deps += 'vhost' cflags += ['-D_FILE_OFFSET_BITS=64'] sources = files( -- 2.20.1