From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id AB0E45F72
for <dev@dpdk.org>; Mon, 4 Feb 2019 10:46:37 +0100 (CET)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
04 Feb 2019 01:46:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,559,1539673200"; d="scan'208";a="115092811"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.138])
by orsmga008.jf.intel.com with SMTP; 04 Feb 2019 01:46:34 -0800
Received: by (sSMTP sendmail emulation); Mon, 04 Feb 2019 10:46:33 +0100
Date: Mon, 4 Feb 2019 10:46:33 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, Luca Boccassi <bluca@debian.org>
Message-ID: <20190204094633.GB21148@bricha3-MOBL.ger.corp.intel.com>
References: <20190131021858.5832-1-3chas3@gmail.com>
<20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com>
<23a3a256-0347-f6ed-c2b8-d923d7a6749d@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23a3a256-0347-f6ed-c2b8-d923d7a6749d@gmail.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
Subject: Re: [dpdk-dev] [PATCH] build: add option to override max ethports
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 09:46:38 -0000
On Thu, Jan 31, 2019 at 06:26:41PM -0500, Chas Williams wrote:
>
>
> On 1/31/19 4:32 AM, Bruce Richardson wrote:
> > On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote:
> > > Allow users and packagers to override the default RTE_MAX_ETHPORTS.
> > > This adds a new meson option, max_ethports which defaults to the
> > > current value.
> > >
> > > Signed-off-by: Chas Williams <3chas3@gmail.com>
> >
> > Agree with the idea. Just one small comment below re alphabetical order.
> >
> > Otherwise:
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> ...
> >
> > We are trying to keep the options in alphabetical order, so this setting
> > should be just before "max_lcores" rather than at the end.
>
> If you look at the last few lines in this file:
>
> option('use_hpet', type: 'boolean', value: false,
> description: 'use HPET timer in EAL')
> option('tests', type: 'boolean', value: true,
> description: 'build unit tests')
>
> I couldn't detect any ordering so I just appended. I can submit a v2.
Yes, that was an oversight that was missed when we were adding those
options, or I just got my alphabet scrambled in my mind. :-) Thanks for the
v2.
>
> > Interestingly, I see that since 0.45 there is now the option of an
> > "integer" option type. We should probably switch to use that once we bump
> > our minimum meson version. [Luca, perhaps another change for your set?]
> > Ref: http://mesonbuild.com/Build-options.html#integers
>
> I just followed along with what everyone else was doing.
Yep, no problem here. Since we still support from 0.41 onwards we can't use
integer anyway, so what you did is perfectly correct.