From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 9B7521B471 for ; Wed, 6 Feb 2019 23:16:57 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id m6so337907pfa.9 for ; Wed, 06 Feb 2019 14:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ikHhKcImjhe7pvxdVffWEKuq8G0RngT5A+y8r832idY=; b=lfxiFNzWbZVFwdmVhPf8it7cjrlbgUUCXI0ZDmGnNqkGIgWAKQI4GPaC1kKIeZr+m9 GmgTErfbECm5nVl0EVVyfBd1npJ+QPb6gLxbbarf/rhAGjHPa3Nsc5Gr908kScszt6y2 9rU4sbBywAsV9aBVdv77O4qQYild9fgToiNre6aqM4Uf+wrkIF5ej6Xm16+jKxDJmLh1 f/GLaEhqhSJoQ38z8Knt9u4Lxf+s7Wc7bxl04HUwtCEfjHEp+aqRRZ8Wmznv04c5WOnv vOd5vEHGPCFrQMzdNzpw0g+D/jCW1JFNkbz46hMOAtRFdwf+JXc2dpJtu5WtKUYcS+G4 NLAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ikHhKcImjhe7pvxdVffWEKuq8G0RngT5A+y8r832idY=; b=EY8jERKG/pKQn1LmQNPq22NXmj5RbjCBaapOvFGXZ2YEuqutbSmzy+B8APNUB8kwFl 66p2chMPW3JVw7VZfMFqJcKcaTjRhKDTUa1elTsUwEED+Fny3Uww8mKchhMQDcL2wQ0E dvQhXKk02hpUuU/kmn0HI1k9NTOuMXQB3yUlrV4PfYV/bGAokGv3pdGsgMl+jkjsZcDC tlwOUo0Xjgk9UP4EnxyjtE6yW0gbwmhXOWdkFXZPS4ZLBJAMvf8s+PVEA+7InOMKukT+ 0z1hsfrEvhRcOK3uyjtm98AuJlymo7LrfdeQKqS8U5WUEAvgVEvJNdQZC7NYnXKjNg33 r/DQ== X-Gm-Message-State: AHQUAua9AeRvSzIELG6KwTje6DmFfNWCkwpAMbmvHvXsFgntTiyPltT0 ATcBulYWefnrTbbVm5yH0qwwuokN4CI= X-Google-Smtp-Source: AHgI3IZaD2399jD+tPCiiJxkS3L97t+Uhyg22083SUGiyW3tQXGFJ7a8ORjms6rqjRxBnlT5GduhKQ== X-Received: by 2002:a62:109b:: with SMTP id 27mr12604771pfq.227.1549491416755; Wed, 06 Feb 2019 14:16:56 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m3sm11195642pfi.102.2019.02.06.14.16.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 14:16:56 -0800 (PST) Date: Wed, 6 Feb 2019 14:16:48 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Matan Azrad , Shahaf Shuler , Yongseok Koh , dev@dpdk.org Message-ID: <20190206141648.5f2d6a99@hermes.lan> In-Reply-To: <20190206215909.30147-1-thomas@monjalon.net> References: <20190206215909.30147-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx: support firmware version query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 22:16:57 -0000 On Wed, 6 Feb 2019 22:59:09 +0100 Thomas Monjalon wrote: > The API function rte_eth_dev_fw_version_get() is querying drivers > via the operation callback fw_version_get(). > The implementation of this operation is added for mlx4 and mlx5. > Both functions are copying the same ibverbs field fw_ver > which is retrieved when calling ibv_query_device[_ex]() > during the port probing. > > It is tested with command "drvinfo" of examples/ethtool/. > > Signed-off-by: Thomas Monjalon Looks good, but hard to test because: * testpmd doesn't report it * with netvsc (and failsafe) the device is owned and not visible Fixing testpmd is not hard, but what is best way to handle the nested device situation.