From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <msantana@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 783E11B468 for <dev@dpdk.org>; Wed, 6 Feb 2019 23:13:11 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A614B88E6F; Wed, 6 Feb 2019 22:13:10 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02E6F87DB; Wed, 6 Feb 2019 22:13:09 +0000 (UTC) From: Michael Santana <msantana@redhat.com> To: dev@dpdk.org Cc: Aaron Conole <aconole@redhat.com>, Bruce Richardson <bruce.richardson@intel.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Thomas Monjalon <thomas@monjalon.net> Date: Wed, 6 Feb 2019 17:13:07 -0500 Message-Id: <20190206221308.22349-2-msantana@redhat.com> In-Reply-To: <20190206221308.22349-1-msantana@redhat.com> References: <20190201164814.11185-1-msantana@redhat.com> <20190206221308.22349-1-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 06 Feb 2019 22:13:10 +0000 (UTC) Subject: [dpdk-dev] [PATCH v4 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 06 Feb 2019 22:13:11 -0000 From: Aaron Conole <aconole@redhat.com> The vhost_scsi example code is set to build, even if the requisite header file virtio_scsi.h isn't available. This happens on some Ubuntu systems when some versions of the libc-dev package aren't available. Check whether the virtio_scsi.h file exists, and if not, set the build flag to false. Signed-off-by: Aaron Conole <aconole@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- v4: Nothing changed in this patch since v3. examples/vhost_scsi/meson.build | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/vhost_scsi/meson.build b/examples/vhost_scsi/meson.build index 2303bcaed..ca1248023 100644 --- a/examples/vhost_scsi/meson.build +++ b/examples/vhost_scsi/meson.build @@ -9,6 +9,11 @@ if host_machine.system() != 'linux' build = false endif + +if not cc.has_header('virtio_scsi.h') + build = false +endif + deps += 'vhost' cflags += ['-D_FILE_OFFSET_BITS=64'] sources = files( -- 2.20.1