From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AFC771B437 for ; Thu, 14 Feb 2019 17:30:39 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2019 08:30:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,369,1544515200"; d="scan'208";a="299761293" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by orsmga005.jf.intel.com with SMTP; 14 Feb 2019 08:30:36 -0800 Received: by (sSMTP sendmail emulation); Thu, 14 Feb 2019 16:30:31 +0000 Date: Thu, 14 Feb 2019 16:30:31 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com Message-ID: <20190214163031.GA415768@bricha3-MOBL.ger.corp.intel.com> References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com> <1550158972-21895-4-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550158972-21895-4-git-send-email-david.marchand@redhat.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 16:30:40 -0000 On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote: > pmd can report transmit errors but those stats are not accounted here. > > Signed-off-by: David Marchand > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 984155a..3acd97b 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1838,6 +1838,7 @@ struct extmem_param { > total_recv += stats.ipackets; > total_xmit += stats.opackets; > total_rx_dropped += stats.imissed; > + port->tx_dropped += stats.oerrors; > total_tx_dropped += port->tx_dropped; > total_rx_nombuf += stats.rx_nombuf; > > Without knowing as to whether the line is needed or not, the line itself looks out of place. All other lines are assignments to local variables, apart from this. Should a local variable be defined for consistency? /Bruce