From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id B829658FE
 for <dev@dpdk.org>; Mon, 18 Feb 2019 15:24:50 +0100 (CET)
Received: from cpe-2606-a000-111b-405a-9816-2c85-c514-8f7a.dyn6.twc.com
 ([2606:a000:111b:405a:9816:2c85:c514:8f7a] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1gvjqY-0002tl-UU; Mon, 18 Feb 2019 09:24:46 -0500
Date: Mon, 18 Feb 2019 09:24:11 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>
Message-ID: <20190218142411.GA9505@hmswarspite.think-freely.org>
References: <20190218123002.26908-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190218123002.26908-1-ferruh.yigit@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Feb 2019 14:24:52 -0000

On Mon, Feb 18, 2019 at 12:30:02PM +0000, Ferruh Yigit wrote:
> Remove KNI ethtool support.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
>  doc/guides/rel_notes/deprecation.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 1b4fcb7e6..0491eeea1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -75,3 +75,11 @@ Deprecation Notices
>  
>  * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be
>    changed from 0.49.0 to 0.52.0.
> +
> +* kni: remove KNI ethtool support. To clarify, this is not to remove the KNI,
> +  but only to remove ethtool support of it that is disabled by default and
> +  can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> +  Existing KNI ethtool implementation is only supported by ``igb`` & ``ixgbe``
> +  drivers, by using a copy of kernel drivers in DPDK. This model can't be extend
> +  to all drivers in DPDK and it is too much effort to maintain kernel modules in DPDK.
> +  As a result users won't be able to use ``ethtool`` via ``igb`` & ``ixgbe`` anymore.
> -- 
> 2.20.1
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>