From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com
 [209.85.215.176]) by dpdk.org (Postfix) with ESMTP id DA34327D
 for <dev@dpdk.org>; Wed, 20 Feb 2019 16:46:53 +0100 (CET)
Received: by mail-pg1-f176.google.com with SMTP id y1so12045834pgk.11
 for <dev@dpdk.org>; Wed, 20 Feb 2019 07:46:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=7so3DGcjQrZpxr7yEt5XE1QAVdwiHTNnovp0xWYQrTY=;
 b=oSYRycKoEFOJGq77B1Og9syWTOAjQKAqWVmkA+w33B4y0Js+iDoTUUtQ+zegIwrqg+
 9Izk7loOGvrJmcXg4QCEiAfHq0Ah7VVaV2EkDEKjSWJGq6K/GrD5kaOKzILZf9+dkRfM
 HcwcKXj9U9G8V1x2l/sk0ebTekMhj1LmRNlMnj0NTjnyKLDTkx3WgCnJMatN/TQFg1/M
 rBBDc5YtqQ/buhLcL9+gfnfbiqXWLWuhBG+FwV9Also/eCeuTBek0SoHHuubGrYR8an1
 RGS7in8bQB/6aIdO4i2ni2JFfUaWSdgLGB9lU3kwWyIL8r+qG3I5sOhaREwK97csjoyf
 bk8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=7so3DGcjQrZpxr7yEt5XE1QAVdwiHTNnovp0xWYQrTY=;
 b=WBqu624iq+P4jEIXQv35On77Gt+q78qLVed5WrhWfO991g3XWXZYWS/QbVvSRjfwa/
 H5wUyKS+kk1qgZm1HaMrHbGzuqHezQ4Du0f7MNMpoSqGvSBSVR4fQeJu6TC4NTPkdixS
 FyiyKmG6TPkoD/Ld+lXeu0aS26NeX6+BTsIFEgO+bRKpB/UEn2VGN6+UPOjHIHze3xjK
 /D3NWr8ViUAT1n1ad7uKEBaCiqVtlKmZR7nsQsch9LBUqdcCfG9sie/EdXPccIdWIAP6
 RczX6nUO+9lpXR7c6WTC6Dan8Jw+wbQ2Djw2ymHBG60Gb0NWmuikmFoCGhZSUr5mrEAg
 Vppw==
X-Gm-Message-State: AHQUAuYgJNfZTYiyyes3JvLlqgVcMJwJe/ZxmngYr53UZsLTUEjy4+Pw
 3DqispqHpyLwmmrhtTbRl3hdiQ==
X-Google-Smtp-Source: AHgI3IYW0lre27hFJ2KBPRocBvpfYui+tH7FuUIp30tP3+hXZetn57lQSMcEbz59ml3MAEmS5sXkcg==
X-Received: by 2002:a63:cc15:: with SMTP id x21mr6607467pgf.380.1550677612488; 
 Wed, 20 Feb 2019 07:46:52 -0800 (PST)
Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.
 [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id y66sm36065965pfy.66.2019.02.20.07.46.52
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 20 Feb 2019 07:46:52 -0800 (PST)
Date: Wed, 20 Feb 2019 07:46:49 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Grajciar <jgrajcia@cisco.com>
Cc: <dev@dpdk.org>
Message-ID: <20190220074649.64056230@shemminger-XPS-13-9360>
In-Reply-To: <20190220115254.18724-1-jgrajcia@cisco.com>
References: <20181213133051.18779-1-jgrajcia@cisco.com>
 <20190220115254.18724-1-jgrajcia@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC v4] /net: memory interface (memif)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2019 15:46:54 -0000

On Wed, 20 Feb 2019 12:52:54 +0100
Jakub Grajciar <jgrajcia@cisco.com> wrote:

> +static int
> +memif_msg_receive_add_ring(struct rte_eth_dev *dev, memif_msg_t *msg, int fd)
> +{
> +	struct pmd_internals *pmd = dev->data->dev_private;
> +	memif_msg_add_ring_t *ar = &msg->add_ring;
> +
> +	if (fd < 0) {
> +		memif_msg_enq_disconnect(pmd->cc, "Missing interrupt fd", 0);
> +		return -1;
> +	}
> +
> +	struct memif_queue *mq;

Minor nit. Please avoid doing c99 style declarations and move this line up to
start of the function.