From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com
 [209.85.210.173]) by dpdk.org (Postfix) with ESMTP id CFE602862
 for <dev@dpdk.org>; Wed, 20 Feb 2019 17:17:44 +0100 (CET)
Received: by mail-pf1-f173.google.com with SMTP id j5so7630777pfa.2
 for <dev@dpdk.org>; Wed, 20 Feb 2019 08:17:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Dve5U6oXj5dpuhkNY9M1o09fNJA2DuusQYg1xOpakwU=;
 b=a2O3C2R4T79lOmuidmKugMtq3jjC25NAYAPdUOvaoIB4OK30un6WOVSk9V6vhPhcp8
 jTxzP1/sU5+P5yzulCJKjDVRMFLM/YQJTTvf0U6kJ9J6itE5pvmwzmcRP1tdSfoCWaQs
 CX/tdtheYdtQWh8OUSVtkBQORH4tOJUJtWNTbPnImhnFmAp3+5/qlZHL2hwNJj7TaZWC
 xAtZRuUPxMf1a+XZEzVmE4HAi2Bsnk4RcRM8Y+btNCwGSo+W/924Nz5mhGomHw3mmEc5
 9cWscyDOuX+QEvWLzIDyzaWpU+iBZnoupJ/5OpJqwH5OvqaMvpJwaANIvliA41ll+L6f
 iVDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Dve5U6oXj5dpuhkNY9M1o09fNJA2DuusQYg1xOpakwU=;
 b=REuyEwARHWqoOvP6/uj0E2djuMzjTPDF62Hn3rjwy7MjyQStuWRCsLXdM22khPGWJL
 gVpsT0+8SddK4yB7KkJKFTyx25hIaYTWAE4g7Bs6DURmCilqNXOqeH0t82QvdwtueyjO
 8W8ZgOD/bhlqjG6qFmyze6fIM6qHUUDxuyygzt02p3xKOIvGdYQ+U3eAuSK+LRHnKC/Q
 /pStrXB1nLV8Q8PSLIy5NVmUsmL0eeUSTqN9YATzqUeflIj1+iYL0XnQ7VIo2ASaJveW
 McDc46h7cXlOHVyaTQVS4Y7FRcUoHp4ugm717vaF/wTicp3JwQyrEk4p3oDkDGeB/akC
 hbog==
X-Gm-Message-State: AHQUAuZUNyseWsM71S4a/eLusD9jaPvWJ/Eod+oNQxY26v3ZcOtQAanO
 NpuEqYjWdeDlmiW7KsDHFe6rQw==
X-Google-Smtp-Source: AHgI3IbwMXKL4KfiUyiFs1mO4HKv1/DgAPRMNhkt5B0i07hk76L4aupbljW5Rb4P6sWnB8fOjGmPgw==
X-Received: by 2002:a63:c948:: with SMTP id y8mr30342212pgg.263.1550679463860; 
 Wed, 20 Feb 2019 08:17:43 -0800 (PST)
Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.
 [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id 64sm29837945pfe.143.2019.02.20.08.17.43
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 20 Feb 2019 08:17:43 -0800 (PST)
Date: Wed, 20 Feb 2019 08:17:40 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Grajciar <jgrajcia@cisco.com>
Cc: <dev@dpdk.org>
Message-ID: <20190220081740.047a6ea7@shemminger-XPS-13-9360>
In-Reply-To: <20190220115254.18724-1-jgrajcia@cisco.com>
References: <20181213133051.18779-1-jgrajcia@cisco.com>
 <20190220115254.18724-1-jgrajcia@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC v4] /net: memory interface (memif)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2019 16:17:45 -0000

On Wed, 20 Feb 2019 12:52:54 +0100
Jakub Grajciar <jgrajcia@cisco.com> wrote:

> +static int
> +memif_msg_enq_init(struct rte_eth_dev *dev)
> +{
> +	struct pmd_internals *pmd = dev->data->dev_private;
> +	struct memif_msg_queue_elt *e = memif_msg_enq(pmd->cc);
<insert blank line here>
> +	if (e == NULL)
> +		return -1

Checkpatch prefers a blank line after declaration and before code.