From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E1ADF29C6; Mon, 25 Feb 2019 08:06:56 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2019 23:06:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,410,1544515200"; d="scan'208";a="141362430" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by orsmga001.jf.intel.com with ESMTP; 24 Feb 2019 23:06:54 -0800 Date: Mon, 25 Feb 2019 15:06:55 +0800 From: Tiwei Bie To: Jiayu Hu Cc: dev@dpdk.org, maxime.coquelin@redhat.com, stable@dpdk.org Message-ID: <20190225070654.GA22485@dpdk-tbie.sh.intel.com> References: <1550823230-16809-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1550823230-16809-1-git-send-email-jiayu.hu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 07:06:57 -0000 On Fri, Feb 22, 2019 at 04:13:50PM +0800, Jiayu Hu wrote: > The VIRTIO_RING_F_EVENT_IDX feature of split ring might > be broken, as the value of signalled_used is unpredictable > after live migration or start up. This patch fixes it by > using signalled_used_valid. Seems you also need to invalidate the signalled_used in e.g. set_vring_base, as signalled_used may not match last_used_idx anymore e.g. when guest driver is reloaded. > > In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX > implementation of split ring match kernel backend to suppress > more interrupts. > > Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppression") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu > --- > lib/librte_vhost/vhost.h | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index fc31796..c4e5e34 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -633,16 +633,20 @@ vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq) > if (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) { > uint16_t old = vq->signalled_used; > uint16_t new = vq->last_used_idx; > + bool signalled_used_valid = vq->signalled_used_valid; > + > + vq->signalled_used = new; > + vq->signalled_used_valid = true; > > VHOST_LOG_DEBUG(VHOST_DATA, "%s: used_event_idx=%d, old=%d, new=%d\n", > __func__, > vhost_used_event(vq), > old, new); > - if (vhost_need_event(vhost_used_event(vq), new, old) > - && (vq->callfd >= 0)) { > - vq->signalled_used = vq->last_used_idx; > + > + if ((vhost_need_event(vhost_used_event(vq), new, old) && > + (vq->callfd >= 0)) || > + unlikely(!signalled_used_valid)) > eventfd_write(vq->callfd, (eventfd_t) 1); > - } > } else { > /* Kick the guest if necessary. */ > if (!(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT) > -- > 2.7.4 >