From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DC7943256 for ; Mon, 25 Feb 2019 16:34:30 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2019 07:34:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,411,1544515200"; d="scan'208";a="137038072" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by orsmga002.jf.intel.com with SMTP; 25 Feb 2019 07:34:27 -0800 Received: by (sSMTP sendmail emulation); Mon, 25 Feb 2019 15:34:26 +0000 Date: Mon, 25 Feb 2019 15:34:26 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20190225153426.GA226940@bricha3-MOBL.ger.corp.intel.com> References: <20190125202642.66559-1-bruce.richardson@intel.com> <20190219145308.65668-1-bruce.richardson@intel.com> <089a7d55-c827-d4a9-2820-a5a160d0e2a6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <089a7d55-c827-d4a9-2820-a5a160d0e2a6@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 15:34:31 -0000 On Wed, Feb 20, 2019 at 11:47:05AM +0000, Ferruh Yigit wrote: > On 2/19/2019 2:53 PM, Bruce Richardson wrote: > > The apps for testing are split between the "test" and "app" directories, > > with a not-very-clear distinction between the two (at least to my mind). > > > > Given how the apps are being built, the easiest path to having > > cmdline_test, test-acl and test-pipeline build using meson is to > > consolidate all these apps back into the app folder and use the logic > > there. The bpf folder doesn't contain an actual application, but > > rather example bpf code which can be loaded into testpmd. That is > > possibly best moved to the examples folder, but I'm open to feedback > > on the best place for it. > > > > With these changes, the "test" folder then becomes the location for > > unit tests only. However, we can simplify things a little by moving > > that too to the app folder, eliminating the need for the separate > > "test-build" make target, and aligning the output folder for the > > binary from "make test-build" with the source file location in app. > > I agree distinction between the "test" and "app" is not very clear, my > motivation to split them was make building test code optional. > > But when split them we have a few cases that tests broken but not recognized for > a while, since we don't have continuous integration that verifies tests perhaps > it can be better to force developers to build them each time to detect issues. > > And as far as I understand this split is causing complications for adding meson > support, if this will make easy to extend meson support overall patchset looks > good to me. > > Thanks, > ferruh > Ping for any further comment or ack. Since this involves moving a lot of files it would be good to get in early to avoid conflicts with later patches which may touch those same files. Thanks, /Bruce