DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: [dpdk-dev] locking around rx_intr_enable/disable?
Date: Tue, 26 Feb 2019 10:14:44 -0800	[thread overview]
Message-ID: <20190226101444.752ee2da@shemminger-XPS-13-9360> (raw)

I noticed an anomaly in how receive interrupt control is done.

In l3fwd-power there is a per-port lock around calls to enable interrupts
but no locking around the call to disable interrupts.  This looks broken
since intr_disable requires multiple operations on some hardware.

There are three better options:
1) do locking in rte_eth_dev (not application)
2) push any necessary locking down into the driver
3) lock on both places in l3fwd-power (and other usages)

I am thinking #1 is easiest solution.

Which ever solution is done, the documentation should be as well.

             reply	other threads:[~2019-02-26 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 18:14 Stephen Hemminger [this message]
2019-02-27  8:57 ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226101444.752ee2da@shemminger-XPS-13-9360 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).