From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 110C62BB8 for ; Tue, 26 Feb 2019 12:24:38 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2019 03:24:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,415,1544515200"; d="scan'208";a="277946133" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.131]) by orsmga004.jf.intel.com with SMTP; 26 Feb 2019 03:24:31 -0800 Received: by (sSMTP sendmail emulation); Tue, 26 Feb 2019 11:24:28 +0000 Date: Tue, 26 Feb 2019 11:24:28 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, Olivier Matz Message-ID: <20190226112427.GA284928@bricha3-MOBL.ger.corp.intel.com> References: <20190125202642.66559-1-bruce.richardson@intel.com> <20190219145308.65668-1-bruce.richardson@intel.com> <20190219145308.65668-2-bruce.richardson@intel.com> <6358435.8ZjemOinAO@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6358435.8ZjemOinAO@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 11:24:39 -0000 On Tue, Feb 26, 2019 at 10:14:08AM +0100, Thomas Monjalon wrote: > 19/02/2019 15:53, Bruce Richardson: > > Move app to "app" directory and enable with meson build. > > > > CC: Olivier Matz > > Signed-off-by: Bruce Richardson > > --- > > MAINTAINERS | 2 +- > > app/Makefile | 1 + > > {test => app}/cmdline_test/Makefile | 0 > > {test => app}/cmdline_test/cmdline_test.c | 0 > > {test => app}/cmdline_test/cmdline_test.h | 0 > > {test => app}/cmdline_test/cmdline_test.py | 0 > > {test => app}/cmdline_test/cmdline_test_data.py | 0 > > {test => app}/cmdline_test/commands.c | 0 > > Sorry, I didn't realize before, > other test apps directories are named test-*. > Shouldn't we name this one test-cmdline? > Looking into it now, changing the directory name is easy enough, however the final binary produced is also called cmdline_test - should it be changed too? Changing it would be a bit more invasive, and would be user-visible (perhaps just to test suites), but would lead to more consistency. NOTE: this only applies to the "make" build, since the meson build uses the directory name as the binary name, so it's already consistent. There is no user visible change here, since the app wasn't available from meson builds before. My recommendation is therefore to rename the directory only, and leave the binary name the same for make builds, given that when we switch completely over to meson it will be consistent at that point. Thoughts, Thomas? /Bruce