From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 9A7F52B9E
 for <dev@dpdk.org>; Fri,  1 Mar 2019 19:31:30 +0100 (CET)
Received: by mail-pg1-f194.google.com with SMTP id l11so11806964pgq.10
 for <dev@dpdk.org>; Fri, 01 Mar 2019 10:31:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=+sPvFYWGb4SrvLJYoNnc/a2jKn0ObT2kqEP3Y793kjU=;
 b=gp/fdK1uesA+cD5NZZ1xGByWTJXgxOcQUakE0oWVPqpwPj+7rqjn2zPIzikX2wW2pq
 m90B3Ib6uJoVBksd4u7cCmRBrF9b/n7YS+qGbtgt4MLWmw5pkH534y1kuhLaJ6N1xqTD
 qXhd9B2WIshbpzH4rS7zGjFwVHo2LWqzOfT+p659PChwgOd0mAEFe1+WKKcqya8Ej5Ua
 u/ISdD8Iv74Qu1XzUdx8ehMTRu9JrseyMwFKBQZtEbUoSvEKOzs9V0A4K/Q/yHQWn3i8
 o5F0uHSLUKC+7ybNc1RktnfHrgMAQm9dOS6L/F0GLT/muKFYicfAgt6sC+V84vCBlbSE
 kH3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=+sPvFYWGb4SrvLJYoNnc/a2jKn0ObT2kqEP3Y793kjU=;
 b=CIytzcaZoW2Dx1zmsNRkn26vpyNV+v4dwR0+7VL2HFbxKehH1Uy+HIHH6fL49kNO0I
 OAgWGga1EXRZbeyuwBUpzX2zO+1IZsSJstsPzwMWMz90nENL30sNh+65wA5t8wroyzxg
 nh6U8a1l8EhJ+0FGjnSvjsIJrly2YKmA7Mnbk4LdvrgGBUjrob89y1nZ4XC2OavCc0Vp
 hLONg92usarh/FT3YOYABQRlY+8WqEwsP24xOWRDko0/GvkUiZAPoMUFDMTaIk8A2zm9
 kZSX/s8qjf/bvfOpj961jAvuawDBUjvKrwgmwEho13cpcVf1TZ0yFUjVJIIb8P9P8KY2
 FZOQ==
X-Gm-Message-State: APjAAAUUuN6GQHyIkbcDXfxaJmQJA9p7V5+8LcpZdMduysGuVyfvE4FG
 gvWOPtcweOLSMT3oE87e//4p8g==
X-Google-Smtp-Source: APXvYqw1hkFPFiDV4Xnk3wFnWuTY8kC1Uv/4vOA54tEJ3ayC2tXmnw6SakCO4mvu2ByQ9Gd7eqiQ0A==
X-Received: by 2002:a62:4817:: with SMTP id v23mr6836597pfa.81.1551465089511; 
 Fri, 01 Mar 2019 10:31:29 -0800 (PST)
Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.
 [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id k7sm56585173pgr.28.2019.03.01.10.31.29
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 01 Mar 2019 10:31:29 -0800 (PST)
Date: Fri, 1 Mar 2019 10:31:25 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Message-ID: <20190301103125.7f6f6b7e@shemminger-XPS-13-9360>
In-Reply-To: <20190301080947.91086-2-xiaolong.ye@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190301080947.91086-2-xiaolong.ye@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD
 driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 18:31:31 -0000

On Fri,  1 Mar 2019 16:09:42 +0800
Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> +	if (umem->buffer)
> +		free(umem->buffer);

Minor nit: you don't need to check for NULL free() already handles this.