From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 55F122C0C
 for <dev@dpdk.org>; Fri,  1 Mar 2019 19:38:52 +0100 (CET)
Received: by mail-pf1-f194.google.com with SMTP id d25so11803130pfn.8
 for <dev@dpdk.org>; Fri, 01 Mar 2019 10:38:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=lu8EXHCzZNJt5Zh+Z2YUFOjM+fUXYpbND3Dj9+zMDZg=;
 b=arGlQdamA9LtUiajdI5YfALjCts22aW/krmDWercyG7MrlSToG0aLocATZVydMerhJ
 Oz+cDGpk8dW7I0pAEciLwV0NL7gtIDA9K8/NFZ+kKKSn27TDHs+CjBP6ERZogruhmN3m
 K9rDNUi6yo1+zmjwskpQIbJF79qDZC4JuUES/e96llTJH3apzN41Hv2L8y0ecJ++4aV/
 lGgoXtmfLzlTHblRazZBw+ONHin+tMaauQCF5gDtCqdrRTnTVdTBiRWJF9L3qW8hSZND
 Dac2UwlevePBNMkYfBnr7UYQlCDa7SIir90t3lluqpM4nLVcfzB3tbAfD+0+K7XaFA27
 xUgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=lu8EXHCzZNJt5Zh+Z2YUFOjM+fUXYpbND3Dj9+zMDZg=;
 b=FdQbQcHWlfEw445PqRcnwDQmpyxOnDTNRphyadcTZuqF/jHaE4x8oACNmbcRPpczRk
 bQ9kzLhlmz5Pmxc/PGth7neknfaRdapFLGycY6WHdRN0KVp2ovv6PrWsHogaGqetaDW3
 QSLs1pXBUsvK3si/R0fnTuF5wZxNzE5kFHMxcDUS8HyDdON00ulhvVkn2SE8e3pcLTXq
 DuOJPlR0QxNIdFrzp87351S2+6XnDypJHpTMsqnq4BlbWnGLJtMjeOLT56AVWUnfVdIV
 slzTrq0mMsxM7pzoUJ1RImv42+BOA8PfPRtjRh0Jzrsen+zJIE91Cm4tDvEsEVEDpfd0
 TykA==
X-Gm-Message-State: APjAAAUYORIWmGDN7gR3NrXT5aGIUKWzB1eMvDCFrOxGXm7Pb4q/A4lh
 T0j9NeKzGfB6aEzLWWe4JR++Jg==
X-Google-Smtp-Source: APXvYqxwoak06WxcM68dnaNt3fhyzfz5Z9EY8rfqFU5lyXwSu18pCzB8RSxY6PhII40XYPeoTLYluQ==
X-Received: by 2002:a63:d357:: with SMTP id u23mr6072564pgi.153.1551465530978; 
 Fri, 01 Mar 2019 10:38:50 -0800 (PST)
Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.
 [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id z7sm45678329pfl.4.2019.03.01.10.38.50
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 01 Mar 2019 10:38:50 -0800 (PST)
Date: Fri, 1 Mar 2019 10:38:47 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org
Message-ID: <20190301103847.64010d3f@shemminger-XPS-13-9360>
In-Reply-To: <20190301124613.66527-2-qiming.yang@intel.com>
References: <20190301124613.66527-1-qiming.yang@intel.com>
 <20190301124613.66527-2-qiming.yang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in
 safe mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 18:38:52 -0000

On Fri,  1 Mar 2019 20:46:13 +0800
Qiming Yang <qiming.yang@intel.com> wrote:

> +	PMD_INIT_LOG(WARNING, "Initialize in safe mode,"
> +		"some features are disabled.\n");

Don't split a message string, it makes it harder to search.

Also, most drivers define PMD_INIT_LOG to always add a newline and do
not add the newline in the macro call.