From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id EB4FB2C38 for ; Fri, 1 Mar 2019 19:40:43 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id b65so8847245plb.6 for ; Fri, 01 Mar 2019 10:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q/rSAkTLnjXkbiRE3itnKLXL35czPTUU7paByD0rhac=; b=nP+VBytVyQ6HwL7nior36yZG5ISDhrIx1LKde9G0JzUwx1Xz+7If9S60K7Dylb12hs e3JrpGNVaxZEPk+jdSqMmM7VzKsufu2qJkxxsnLZ960O4Xkt31EfFm1yc3KE3wGQ3Vhv JtkOqjT/rAJRioNwRF5AOza/l39jGQMST7ndflrfS4eT3HJasv+3U69cGc0gNtfxREdf ILLdIobdqYC2mxR57xeIRfexUpUbg79NbcvSzavoeDnK545xlK0KUKrrFObYauFGbImv 1lMCHF9UrIsXoBpgjLhr/Ka+Gro4EqhElwPlHKWeHV+3vSq5JsoItKdXiMsDdqYYIUcp wlkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q/rSAkTLnjXkbiRE3itnKLXL35czPTUU7paByD0rhac=; b=F0NLm3cDhAmIYNt8iAWqGq9jfx5r4UywNPIUkk//9NuSudynGJd7q6GC/xGl8ksWmA G9CbsVLbIhi0hHbAfh3R3viM8JTC21aSiGHHbXGSmYrhoos6RvL7rA/mqAgdfCdtMCeS HlLpNhrFEDohDqC0S30pkqqwNQ35M8DNu8gCiYYY8K/hnQo2/u68v7cpV6D4OKr/QnMz 8FUM5SjD2xwT5DU6/8MHZ+3uOBdZDwYUxUMb/qYAo17H/xiFQFM1yijMYVlOJC9Ixbpa lNHzH06Uct+VeUXqDvwm1mAo7irS5myexmTDyBp8idAthT+/ZqGTG3dIpYJWjwsXPl/x 2KnA== X-Gm-Message-State: APjAAAWjJX3Z+gFQdskxkgIct+lje2x9rfQZafPHnO3H2e/WBuNlUEwM CARq5ePUTn0PjgmGQOdOj0dRntSNANM= X-Google-Smtp-Source: APXvYqzxaXrbQom8GOehtNYtYhaPd0LERp/G7q69dp86qrkGTHwyWAR29CX+FUA5OaD/jVV/p5S+/w== X-Received: by 2002:a17:902:8f81:: with SMTP id z1mr7063457plo.265.1551465643122; Fri, 01 Mar 2019 10:40:43 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n6sm36558741pgh.79.2019.03.01.10.40.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 10:40:43 -0800 (PST) Date: Fri, 1 Mar 2019 10:40:41 -0800 From: Stephen Hemminger To: Qiming Yang Cc: dev@dpdk.org Message-ID: <20190301104041.166ae95a@shemminger-XPS-13-9360> In-Reply-To: <20190301124613.66527-1-qiming.yang@intel.com> References: <20190301124613.66527-1-qiming.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 18:40:44 -0000 On Fri, 1 Mar 2019 20:46:12 +0800 Qiming Yang wrote: > + > + if (kvargs_count > 1) > + PMD_DRV_LOG(WARNING, "More than one argument \"%s\" and only " > + "the first invalid or last valid one is used !", Do not add line breaks to error message strings, it makes it harder to find them in the source with tools like grep