From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id E0DD22BA5 for ; Fri, 8 Mar 2019 18:29:40 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id d25so14617317pfn.8 for ; Fri, 08 Mar 2019 09:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n3BqPCpY6LGfzDb4eO7+hBolNwPY6NAlrlsWTTQFZSY=; b=UaEu6ISyW3Gnlhhh/OHlbPUr8VO/zwk8rolNtiXxr4HF7FF+5o5rMqO2ZtiBeH0Bkj mNRnfh3Jkq8lvCOnIiA5C939/7eOgg/ueRkex4oytL07EYHi/m/o0jf+f21xWkQZwxmb UnvSl4lXGd/az6xRxo/K5I4oDNZMemlj2JCwiy9KH43okNgPKmyIgQOSh243XE+fYcYd gKWOFJavhcS29RfxpKzQ29i7WpRROuPV/8fBg5c18eG+HQQ+YyEhX8UXbg+WFh0w7IT2 FalMrig1gqQr0Iu07lFEofd9OckI9wSB/V3noW8eZplHuKK/Hs2WkVyxETY9wf171fj0 vNgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n3BqPCpY6LGfzDb4eO7+hBolNwPY6NAlrlsWTTQFZSY=; b=RA9qW6glxNwZk3arueBdIlbBUNd1oPjpyQW/o+9HtMau95t/tIvxN/mKxeJtKfHRhn IqkKfXQmLuM63jIsjXf9j9WN6m1Rx8YTPqPQJbDJ+LHG2HfgIzg6kUGrkX+Dv+bI2SpE 5MSIJ7xBvi12j9keLiR7NoeyqC5/gtSQes5k/qDPDDL0dYFG7Yz5MCiSGX8/GHcy3xVC 7cHbWEUrS2Ltjg+emB39z5XxMpq9AJh22RfMDJRX6uOG0OMgIBFIr46+rNENIZ3hVn+p ebxUObXiPRi5vTVCAz+AyNycrL5kvULkJaA8AvGEx521S7u6RaGZQoicXHdhrg0PZDsT i8/A== X-Gm-Message-State: APjAAAXRUbuj26aApqpNpl5Mv7urtZgGB98wliazgbQmEkN0QBKq/jOq k/fHq2/Uh7ezh9EENWigL6Rk0A== X-Google-Smtp-Source: APXvYqx57ZxHTztdWk3wxCxPnDOIoIgHBceZSFLMCncCs8JUhui/xnWtXFapZ8VLXJRV/R39xajQ7A== X-Received: by 2002:a17:902:8bc2:: with SMTP id r2mr20132331plo.55.1552066179924; Fri, 08 Mar 2019 09:29:39 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l5sm14996113pfi.97.2019.03.08.09.29.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Mar 2019 09:29:39 -0800 (PST) Date: Fri, 8 Mar 2019 09:29:37 -0800 From: Stephen Hemminger To: olegpoly123 Cc: keith.wiles@intel.com, thomas@monjalon.net, dev@dpdk.org, stable@dpdk.org, Oeg Polyakov Message-ID: <20190308092937.05330e54@shemminger-XPS-13-9360> In-Reply-To: <20190308155547.1695-1-olegp123@walla.co.il> References: <20190308155547.1695-1-olegp123@walla.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/tap: fix missing _SC_IOV_MAX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 17:29:41 -0000 On Fri, 8 Mar 2019 10:55:46 -0500 olegpoly123 wrote: > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 6f5109fca..cd48b2b2a 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -1326,6 +1326,11 @@ tap_rx_queue_setup(struct rte_eth_dev *dev, > struct rx_queue *rxq = &internals->rxq[rx_queue_id]; > struct rte_mbuf **tmp = &rxq->pool; > long iov_max = sysconf(_SC_IOV_MAX); > + if (iov_max <= 0) { > + TAP_LOG(WARNING, > + "_SC_IOV_MAX is not defined. Using 1024 as default\n"); > + iov_max = 1024; > + } Blank line between declarations and code please. This should never happen except for redhat bug: https://bugzilla.redhat.com/show_bug.cgi?id=1504165