From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes
Date: Thu, 14 Mar 2019 16:12:00 +0100 [thread overview]
Message-ID: <CAJFAV8wAM-k7mvzwo6fe1P5x=fM5s2-qyHvayJhZ_y2E=Hy6Jg@mail.gmail.com> (raw)
Message-ID: <20190314151200.DUYZitpQpJaSEE_uHU-OLwhJdBniyiEYOYS1I5lf9rQ@z> (raw)
In-Reply-To: <CAJFAV8yUF_cxD6Sg_FP+gg=zaPsQbG2M3rLNvGWfpLVgKkEA+w@mail.gmail.com>
On Mon, Mar 11, 2019 at 7:09 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Mon, Mar 11, 2019 at 6:22 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
>
>> On 3/4/2019 11:18 AM, David Marchand wrote:
>> > According to the api, the q_errors[] per queue statistic is for
>> reception
>> > errors not transmit errors.
>> > This is a first cleanup on statistics before looking at oerrors.
>> >
>>
>> Yes, the patchset looks aligned with the API documentation [1].
>>
>> What can be the solution after cleanup? We can merge this cleanup and
>> solution
>> next to each-other to not leave a gap?
>> 1- Different variables for Rx and Tx errors?
>> 2- Combine Rx & Tx into this single variable?
>>
>> It can be good to find a solution because new PMDs doing same mistake
>> because of
>> copy/paste...
>>
>
> Might not be feasible but how about we could introduce an internal stats
> structure containing the needed field for tx.
> pmd would use it but ethdev would translate it to the current exposed api
> rte_eth_dev_stats_get ?
> The additional field would be formatted by ethdev to be provided through
> the xstats api.
>
Sending RFC patches to have something to discuss on.
--
David Marchand
next prev parent reply other threads:[~2019-03-14 15:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 11:18 David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 01/12] net/af_packet: fix incorrect rxq errors stat David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 02/12] net/avp: " David Marchand
2019-03-04 12:18 ` Legacy, Allain
2019-03-04 11:18 ` [dpdk-dev] [PATCH 03/12] net/bnxt: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 04/12] net/cxgbe: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 05/12] net/kni: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 06/12] net/mlx4: " David Marchand
2019-03-05 8:19 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-dev] [PATCH 07/12] net/mlx5: " David Marchand
2019-03-05 8:18 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-dev] [PATCH 08/12] net/null: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 09/12] net/pcap: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 10/12] net/ring: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 11/12] net/szedata2: " David Marchand
2019-03-04 11:18 ` [dpdk-dev] [PATCH 12/12] net/tap: " David Marchand
2019-03-04 13:58 ` Wiles, Keith
2019-03-11 17:22 ` [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes Ferruh Yigit
2019-03-11 18:09 ` David Marchand
2019-03-14 15:12 ` David Marchand [this message]
2019-03-14 15:12 ` David Marchand
2019-03-14 15:13 ` [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API David Marchand
2019-03-14 15:13 ` David Marchand
2019-03-14 15:13 ` [dpdk-dev] [RFC PATCH 2/2] net/af_packet: convert to new " David Marchand
2019-03-14 15:13 ` David Marchand
2019-03-15 13:30 ` [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal " David Marchand
2019-03-15 13:30 ` David Marchand
2019-03-19 17:18 ` Ferruh Yigit
2019-03-19 17:18 ` Ferruh Yigit
2019-03-19 17:54 ` Stephen Hemminger
2019-03-19 17:54 ` Stephen Hemminger
2019-04-12 13:18 ` Thomas Monjalon
2019-04-12 13:18 ` Thomas Monjalon
2019-03-26 9:29 ` David Marchand
2019-03-26 9:29 ` David Marchand
2019-04-12 13:29 ` Thomas Monjalon
2019-04-12 13:29 ` Thomas Monjalon
2019-04-12 14:32 ` David Marchand
2019-04-12 14:32 ` David Marchand
2019-04-12 16:05 ` Stephen Hemminger
2019-04-12 16:05 ` Stephen Hemminger
2019-04-12 15:07 ` [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes Thomas Monjalon
2019-04-12 15:07 ` Thomas Monjalon
2019-04-12 15:38 ` Ferruh Yigit
2019-04-12 15:38 ` Ferruh Yigit
2019-04-12 15:45 ` Thomas Monjalon
2019-04-12 15:45 ` Thomas Monjalon
2019-04-12 15:57 ` Ferruh Yigit
2019-04-12 15:57 ` Ferruh Yigit
2019-05-28 21:38 ` Yigit, Ferruh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wAM-k7mvzwo6fe1P5x=fM5s2-qyHvayJhZ_y2E=Hy6Jg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).