From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: Rami Rosen <ramirose@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
Date: Fri, 15 Mar 2019 10:39:58 +0000 [thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020A7FA8@IRSMSX104.ger.corp.intel.com> (raw)
Message-ID: <20190315103958.GKVDVk-eB5t0DEHDtO6XimSjUP-lTTGT2sOKnHNMOkI@z> (raw)
In-Reply-To: <20190315091900.18996-1-ramirose@gmail.com>
> This patch fixes two typos in the coding style part of DPDK contributing guide:
>
> - The header entry should have .h file instead of .c file.
> - The will->This will
>
> Fixes: 44a6dface13b ("doc: describe how to add new components")
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> doc/guides/contributing/coding_style.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst
> b/doc/guides/contributing/coding_style.rst
> index d96698a73..656563dde 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -825,10 +825,10 @@ format.
> .. code-block:: python
>
> sources = files('file1.c', ...)
> - headers = files('file1.c', ...)
> + headers = files('file1.h', ...)
>
>
> -The will build based on a number of conventions and assumptions within the
> DPDK
> +This will build based on a number of conventions and assumptions within
> +the DPDK
> itself, for example, that the library name is the same as the directory name
> in which the files are stored.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
next prev parent reply other threads:[~2019-03-15 10:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 9:19 Rami Rosen
2019-03-15 9:19 ` Rami Rosen
2019-03-15 10:39 ` Kovacevic, Marko [this message]
2019-03-15 10:39 ` Kovacevic, Marko
2019-04-05 8:00 ` Thomas Monjalon
2019-04-05 8:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DC05C7C5F25994B81B3F2F214251F66020A7FA8@IRSMSX104.ger.corp.intel.com \
--to=marko.kovacevic@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).