Re: [dpdk-dev] [PATCH v3 2/8] net/ice: add pointer for queue buffer release

["Lu, Wenzhuo" <wenzhuo.lu@intel.com>]

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, March 16, 2019 1:53 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/8] net/ice: add pointer for queue buffer
> release
> 
> On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:
> > Add function pointers of buffer releasing for RX and TX queues, for
> > vector functions will be added for RX and TX.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
> <...>
> 
> > @@ -27,6 +27,9 @@
> >
> >  #define ICE_SUPPORT_CHAIN_NUM 5
> >
> > +typedef void (*ice_rx_release_mbufs)(struct ice_rx_queue *rxq);
> > +typedef void (*ice_tx_release_mbufs)(struct ice_tx_queue *txq);
> > +
> >  struct ice_rx_entry {
> >  	struct rte_mbuf *mbuf;
> >  };
> > @@ -61,6 +64,7 @@ struct ice_rx_queue {
> >  	uint16_t max_pkt_len; /* Maximum packet length */
> >  	bool q_set; /* indicate if rx queue has been configured */
> >  	bool rx_deferred_start; /* don't start this queue in dev start */
> > +	ice_rx_release_mbufs rx_rel_mbufs;
> >  };
> >
> >  struct ice_tx_entry {
> > @@ -100,6 +104,7 @@ struct ice_tx_queue {
> >  	uint16_t tx_next_rs;
> >  	bool tx_deferred_start; /* don't start this queue in dev start */
> >  	bool q_set; /* indicate if tx queue has been configured */
> > +	ice_tx_release_mbufs tx_rel_mbufs;
> 
> We are not using suffixes as coding convention, and indeed it says "Avoid
> typedefs ending in _t" explicitly, but for this case it is not clear that they are
> function pointers.
> 
> So what do you think either appending a _t suffix, or putting verb to the end
> to more sound like function more than object:
> ice_tx_mbufs_release_t
Thanks for  the comment. Better to distinguish the function pointers from others. I'll add "_t".