From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 00A97A00E6
	for <public@inbox.dpdk.org>; Tue, 19 Mar 2019 10:41:54 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C9EAB2956;
	Tue, 19 Mar 2019 10:41:53 +0100 (CET)
Received: from out20-75.mail.aliyun.com (out20-75.mail.aliyun.com
 [115.124.20.75]) by dpdk.org (Postfix) with ESMTP id DBF0111A4
 for <dev@dpdk.org>; Tue, 19 Mar 2019 10:41:34 +0100 (CET)
X-Alimail-AntiSpam: AC=CONTINUE; BC=0.07513699|-1; CH=green;
 DM=CONTINUE|CONTINUE|true|0.0170761-0.00455848-0.978365; FP=0|0|0|0|0|-1|-1|-1;
 HT=e01l07391; MF=hfli@netitest.com; NM=1; PH=DS; RN=3; RT=3; SR=0;
 TI=SMTPD_---.EA.VLya_1552988485; 
Received: from PC20180210SSYA(mailfrom:hfli@netitest.com
 fp:SMTPD_---.EA.VLya_1552988485)
 by smtp.aliyun-inc.com(10.147.42.135);
 Tue, 19 Mar 2019 17:41:26 +0800
From: <hfli@netitest.com>
To: <declan.doherty@intel.com>,
	<chas3@att.com>,
	<dev@dpdk.org>
Date: Tue, 19 Mar 2019 17:41:25 +0800
Message-ID: <001a01d4de37$ec097f80$c41c7e80$@netitest.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdTeNnQNuMFaxxzYQ3e9jJI1rHiu9A==
Content-Language: zh-cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] 8023ad bond tx crashed if one port has 2 more tx queues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190319094125._Yzzn3tyAsibmRY7GOPigzlw3HFfJXrmkZJAPPyprdQ@z>

Hi Guys,

 

I found a bug in dpdk bond code, while one port has 2 more tx queues, 8023ad
bond port will be crashed in tx burst.

 

Just analyzed the code below, if 2 more CPU cores send packets on a port by
different tx queue, the arrays like 

slave_port_ids/ dist_slave_port_ids/ slave_tx_fail_coun/ slave_bufs will be
shared by all of cores, it will be crashed in this function.

 

Is there any better solution for this? For now, I just add lock for
rte_eth_tx_burst.

 

 

static uint16_t

bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,

                   uint16_t nb_bufs)

{

         struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;

         struct bond_dev_private *internals = bd_tx_q->dev_private;

 

         uint16_t [RTE_MAX_ETHPORTS];

         uint16_t slave_count;

 

         uint16_t dist_slave_port_ids[RTE_MAX_ETHPORTS];

         uint16_t dist_slave_count;

 

         /* 2-D array to sort mbufs for transmission on each slave into */

         struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_bufs];

         /* Number of mbufs for transmission on each slave */

         uint16_t slave_nb_bufs[RTE_MAX_ETHPORTS] = { 0 };

         /* Mapping array generated by hash function to map mbufs to slaves
*/

         uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };

 

         uint16_t slave_tx_count, slave_tx_fail_count[RTE_MAX_ETHPORTS] = {
0 };

         uint16_t total_tx_count = 0, total_tx_fail_count = 0;

 

 

 

Thanks and Regards,

Haifeng