From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D0F9311A4 for ; Tue, 19 Mar 2019 11:29:09 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 03:29:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="135537033" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga007.fm.intel.com with ESMTP; 19 Mar 2019 03:29:07 -0700 Date: Tue, 19 Mar 2019 18:28:53 +0800 From: Tiwei Bie To: Jens Freimann Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20190319102852.GA8090@dpdk-tbie.sh.intel.com> References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-11-tiwei.bie@intel.com> <20190319100424.oajlkmjiahdka373@jenstp.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190319100424.oajlkmjiahdka373@jenstp.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 10:29:10 -0000 On Tue, Mar 19, 2019 at 11:04:24AM +0100, Jens Freimann wrote: > On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote: > > This patch improves descriptors refill by using the same > > batching strategy as done in in-order and mergeable path. > > > > Signed-off-by: Tiwei Bie > > --- > > drivers/net/virtio/virtio_rxtx.c | 60 ++++++++++++++++++-------------- > > 1 file changed, 34 insertions(+), 26 deletions(-) > > > Looks good. How much do we gain by this? The gain is very visible on my side. E.g. for packed ring, the PPS changed from ~10786973 to ~11636990 in a macfwd test between two testpmds. Thanks, Tiwei > > Reviewed-by: Jens Freimann > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2A820A00E6 for ; Tue, 19 Mar 2019 11:29:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E9781B19; Tue, 19 Mar 2019 11:29:12 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D0F9311A4 for ; Tue, 19 Mar 2019 11:29:09 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 03:29:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="135537033" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga007.fm.intel.com with ESMTP; 19 Mar 2019 03:29:07 -0700 Date: Tue, 19 Mar 2019 18:28:53 +0800 From: Tiwei Bie To: Jens Freimann Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20190319102852.GA8090@dpdk-tbie.sh.intel.com> References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-11-tiwei.bie@intel.com> <20190319100424.oajlkmjiahdka373@jenstp.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190319100424.oajlkmjiahdka373@jenstp.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319102853.iAbDXUDfEsCOfjRVN7Cce2Q9Fr-FLgzTT5D7a36R3Z8@z> On Tue, Mar 19, 2019 at 11:04:24AM +0100, Jens Freimann wrote: > On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote: > > This patch improves descriptors refill by using the same > > batching strategy as done in in-order and mergeable path. > > > > Signed-off-by: Tiwei Bie > > --- > > drivers/net/virtio/virtio_rxtx.c | 60 ++++++++++++++++++-------------- > > 1 file changed, 34 insertions(+), 26 deletions(-) > > > Looks good. How much do we gain by this? The gain is very visible on my side. E.g. for packed ring, the PPS changed from ~10786973 to ~11636990 in a macfwd test between two testpmds. Thanks, Tiwei > > Reviewed-by: Jens Freimann > >