From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1E643A00E6 for ; Tue, 19 Mar 2019 12:08:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C0502956; Tue, 19 Mar 2019 12:08:18 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 05F841B19 for ; Tue, 19 Mar 2019 12:08:15 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21AD981104; Tue, 19 Mar 2019 11:08:15 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4723B6199C; Tue, 19 Mar 2019 11:08:09 +0000 (UTC) To: Tiwei Bie , Jens Freimann Cc: zhihong.wang@intel.com, dev@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-11-tiwei.bie@intel.com> <20190319100424.oajlkmjiahdka373@jenstp.localdomain> <20190319102852.GA8090@dpdk-tbie.sh.intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 19 Mar 2019 12:08:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319102852.GA8090@dpdk-tbie.sh.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 19 Mar 2019 11:08:15 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319110807.dwItvthNOCPgDpXsmcXpTtIBQfqkef791qX-lYm5fps@z> On 3/19/19 11:28 AM, Tiwei Bie wrote: > On Tue, Mar 19, 2019 at 11:04:24AM +0100, Jens Freimann wrote: >> On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote: >>> This patch improves descriptors refill by using the same >>> batching strategy as done in in-order and mergeable path. >>> >>> Signed-off-by: Tiwei Bie >>> --- >>> drivers/net/virtio/virtio_rxtx.c | 60 ++++++++++++++++++-------------- >>> 1 file changed, 34 insertions(+), 26 deletions(-) >>> >> Looks good. How much do we gain by this? > > The gain is very visible on my side. E.g. for packed ring, > the PPS changed from ~10786973 to ~11636990 in a macfwd test > between two testpmds. Nice! > Thanks, > Tiwei > >> >> Reviewed-by: Jens Freimann >> >>