From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D4738A00E6 for ; Tue, 19 Mar 2019 13:49:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6E1911A4; Tue, 19 Mar 2019 13:49:26 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A4894A3; Tue, 19 Mar 2019 13:49:25 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 135AEC04959D; Tue, 19 Mar 2019 12:49:25 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E59A1272BC; Tue, 19 Mar 2019 12:49:23 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stable@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-4-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <968db386-f515-3a5e-789b-7f5f2caac38e@redhat.com> Date: Tue, 19 Mar 2019 13:49:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319064312.13743-4-tiwei.bie@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 19 Mar 2019 12:49:25 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 03/10] net/virtio: add missing barrier in interrupt enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319124922.ELrcf5QyUT5gPK6-ZPkEOusrb0sQoTBM0qZ5JHqwC3Q@z> On 3/19/19 7:43 AM, Tiwei Bie wrote: > Typically, after enabling Rx interrupt, a check should be done > to make sure that there is no new incoming packets before going > to sleep. So a barrier is needed to make sure that any following > check won't happen before the interrupt is actually enabled. > > Fixes: c056be239db5 ("net/virtio: add Rx interrupt enable/disable functions") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Maxime Coquelin Thanks, Maxime