DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Rami Rosen <ramirose@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix a typo.
Date: Tue, 19 Mar 2019 17:24:21 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D731A8@IRSMSX108.ger.corp.intel.com> (raw)
Message-ID: <20190319172421.YFUIzjV77J_RcWWc6wi7LUNBlyiFx9fwzyOAJWr0I7Y@z> (raw)
In-Reply-To: <20190312054843.26184-1-ramirose@gmail.com>

Hi Rami,

> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Tuesday, March 12, 2019 5:49 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Rami Rosen <ramirose@gmail.com>
> Subject: [PATCH] app/testpmd: fix a typo.
> 
> This patch fixes a typo in test-pmd/cmdline.c:
> succcessfully->successfully
> Two C's are good enough for success...
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> db53cc0cc..815e5e887 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -12076,7 +12076,7 @@ cmd_set_hash_global_config_parsed(void
> *parsed_result,
>  							res->port_id);
>  	else
>  		printf("Global hash configurations have been set "
> -			"succcessfully by port %d\n", res->port_id);
> +			"successfully by port %d\n", res->port_id);
>  }
> 
>  cmdline_parse_token_string_t cmd_set_hash_global_config_all =
> --
> 2.17.1
#/dpdk./devtools/check-git-log.sh -1
Wrong headline format:
        app/testpmd: fix a typo.
Wrong tag:
        This patch fixes a typo in test-pmd/cmdline.c:
Missing 'Fixes' tag:
        app/testpmd: fix a typo.

This patch should have a fixes line and "typo." seems to be causing an error.

Regards,

Bernard.


  reply	other threads:[~2019-03-19 17:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12  5:48 Rami Rosen
2019-03-19 17:24 ` Iremonger, Bernard [this message]
2019-03-19 17:24   ` Iremonger, Bernard
2019-03-19 18:30 ` Ferruh Yigit
2019-03-19 18:30   ` Ferruh Yigit
2019-03-20 11:19   ` Iremonger, Bernard
2019-03-20 11:19     ` Iremonger, Bernard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260D731A8@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=ramirose@gmail.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).