From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 61A0AA00E6 for ; Tue, 19 Mar 2019 18:36:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD66D1DBD; Tue, 19 Mar 2019 18:36:38 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id D643F11A4; Tue, 19 Mar 2019 18:36:36 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id o1so2811789wrs.13; Tue, 19 Mar 2019 10:36:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=GQxsJ//OIetK+FU8eoZsvjdeflXYyj05rSwT/nnvup8=; b=VidM1sHFOSdWvIkPBCRn//QZrQDLOEfP78vEE+1RdUTyIoTPA/9iOeqtoRx3l/exdy ATO7zLYWqHC5FUqmkV6D/sHcCwqFCPikFpjxKKcdZWVx5EF3rP3797kwrdFHqZEQAY5P kcMW+FHipElVBhjozXiur70WVodJA1JLX9nKrGhDyxQm5dJx//qhHzhEaMF3Xv+4Q2uR FNuGnC+rBWZTEbA++5T89Oprz/yS+p44KVQ9Kb0HsNbh0/gaO0uz118JGz3bXN8vcvV3 1/Q3v1+qlCaJEvrHkYWk2ZKyLyQ0fBkb7E1R6AFk9rDt3yACOz76fjYEDkcaqgDG0aeu 3GqA== X-Gm-Message-State: APjAAAVB/JJOSJUZXpmfRM1All/zIMMouRH9mOjEdi44WzVlq+hQ3Cm8 ntsLmJ+NQjbUyGfWFQyaCZeJuLdTWTQ= X-Google-Smtp-Source: APXvYqzb4OkpM7mODo8o12DcMk98BmFfFMFwyhhMqhjY7JI4vLCJhEMkogxRJzE/4p6p1+wczjd6Ug== X-Received: by 2002:adf:ba84:: with SMTP id p4mr18243541wrg.156.1553016996565; Tue, 19 Mar 2019 10:36:36 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id x22sm3610259wmc.19.2019.03.19.10.36.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 10:36:35 -0700 (PDT) Message-ID: <1bc7f7793e60adc4abd36568b346bdcf0569ba64.camel@debian.org> From: Luca Boccassi To: Jerin Jacob Kollanukkaran , Thomas Monjalon Cc: "dev@dpdk.org" , "bruce.richardson@intel.com" , "stable@dpdk.org" Date: Tue, 19 Mar 2019 17:36:35 +0000 In-Reply-To: <20190319172150.12765-1-jerinj@marvell.com> References: <20190318162804.28974-1-jerinj@marvell.com> <20190319172150.12765-1-jerinj@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] meson: remove build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319173635.FYVdIca1DOglhpoYf_zHVbRbWbANSUBuUet-GMtrY4Q@z> On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote: > From: Jerin Jacob >=20 > Remove the following warning by comparing string to string. >=20 > config/arm/meson.build:153: WARNING: Trying to compare values of > different types (list, str) using =3D=3D. >=20 > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for > ARM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jerin Jacob > --- >=20 > v2: Remove meson version related warning as bumbing the version needs > techboard approval. >=20 > --- > config/arm/meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 8e892fa77..170a4981a 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -116,8 +116,8 @@ else > cmd_output =3D > cmd.stdout().to_lower().strip().split(' ') > endif > # Set to generic if variable is not found > - machine =3D get_variable('impl_' + cmd_output[0], > 'generic') > - if machine =3D=3D 'generic' > + machine =3D get_variable('impl_' + cmd_output[0], > ['generic']) > + if machine[0] =3D=3D 'generic' > machine =3D impl_generic > cmd_output =3D cmd_generic > endif Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi