From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 49551A00E6 for ; Wed, 20 Mar 2019 03:12:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01E0F2C60; Wed, 20 Mar 2019 03:12:53 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 720D12BAF for ; Wed, 20 Mar 2019 03:12:51 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 19:12:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,246,1549958400"; d="scan'208";a="328819758" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga006.fm.intel.com with ESMTP; 19 Mar 2019 19:12:48 -0700 Date: Wed, 20 Mar 2019 10:08:52 +0800 From: Ye Xiaolong To: Jerin Jacob Kollanukkaran Cc: "dev@dpdk.org" , "olivier.matz@6wind.com" , "magnus.karlsson@intel.com" , "qi.z.zhang@intel.com" , "bjorn.topel@intel.com" Message-ID: <20190320020852.GE16135@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190319071256.26302-1-xiaolong.ye@intel.com> <20190319071256.26302-7-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320020852.f5cXH7oHoWaEBZzpsLfnS-QF2odsFTCqjSAGdmucHso@z> Hi, On 03/19, Jerin Jacob Kollanukkaran wrote: >On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: >> When create rte_mempool, flags can be parsed from command line. >> Now, it is possible for testpmd to create a af_xdp friendly >> mempool (which enable zero copy). >> >> Signed-off-by: Qi Zhang >> Signed-off-by: Xiaolong Ye >> --- >> app/test-pmd/parameters.c | 12 ++++++++++++ >> app/test-pmd/testpmd.c | 17 ++++++++++------- >> app/test-pmd/testpmd.h | 1 + >> doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > >If I understand it correctly, The user needs to change all the >application in order to avail zero copy feature of XDP. > >If so, > >How about creating wrapper mempool driver for xdp at drivers/mempool/? >and mempool's best mempool feature to select the required mempool >driver for XDP at runtime without changing the apps. > >see rte_mbuf_best_mempool_ops() >see struct eth_dev_ops::pool_ops_supported Sounds a good suggestion, I'll investigate and see how to implement it. Thanks, Xiaolong > >/Jerin > > > >