From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5A9B2A00E6 for ; Wed, 20 Mar 2019 08:34:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C19F11A4; Wed, 20 Mar 2019 08:34:51 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C2B7B10A3 for ; Wed, 20 Mar 2019 08:34:49 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD97437E8B; Wed, 20 Mar 2019 07:34:48 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3B532C8DF; Wed, 20 Mar 2019 07:34:46 +0000 (UTC) To: dev@dpdk.org, i.maximets@samsung.com, changpeng.liu@intel.com, tiwei.bie@intel.com, dariusz.stojaczyk@intel.com References: <20190319105417.16890-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <2c534558-7e69-fcd6-f477-1da6b021bcb2@redhat.com> Date: Wed, 20 Mar 2019 08:34:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319105417.16890-1-maxime.coquelin@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 20 Mar 2019 07:34:48 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320073443.090r6mnJmU-OmNi3mQr-YlhWVcyF2ETeIR8yDKTVySw@z> On 3/19/19 11:54 AM, Maxime Coquelin wrote: > The goals of this series is to provide more flexibility to external > backends to implement their specific vhost-user request handling > without having to patch vhost-user library. > > First patch implements a new API for external backend to advertize > its specific protocol features to vhost-user master. > > Second patch ensures a request not handled by the vhost-user library > but by the external backend only will not be treated as an error or > make the vhost lib to crash. > > Changes in v3: > ============== > - Fix and improve comments (Ilya) > > Changes in v2: > ============== > - Remove 'skip_master' param from documentation (Ilya) > - Merge pre and post callback in a single one (Ilya) > > Changes in v1: > ============== > - Convert vhost-crypto to the API change (Ilya) > - Fix build with recent GCC (fall-through) > - Check request > VHOST_USER_NONE (Ilya) > - Remove 'Requested invalid message type' check (Ilya) > > Changes in RFC v2: > ================== > - Fix build & git message > - Add new enum for not handled messages & remove skip_master (Ilya) > > Maxime Coquelin (2): > vhost: add API to set protocol features flags > vhost: support requests only handled by external backend > > lib/librte_vhost/rte_vhost.h | 53 +++++++++-------- > lib/librte_vhost/rte_vhost_version.map | 1 + > lib/librte_vhost/socket.c | 14 +++++ > lib/librte_vhost/vhost_crypto.c | 10 +++- > lib/librte_vhost/vhost_user.c | 82 ++++++++++++++++---------- > 5 files changed, 102 insertions(+), 58 deletions(-) > Applied to dpdk-next-virtio/master branch. Thanks, Maxime