From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 79F4DA00E6 for ; Wed, 20 Mar 2019 08:35:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 426CD11A4; Wed, 20 Mar 2019 08:35:43 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E4DD010A3; Wed, 20 Mar 2019 08:35:41 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A75E308429D; Wed, 20 Mar 2019 07:35:41 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D0D51001E71; Wed, 20 Mar 2019 07:35:39 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stephen@networkplumber.org, ferruh.yigit@intel.com, stable@dpdk.org References: <20190312071307.19393-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 20 Mar 2019 08:35:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190312071307.19393-1-tiwei.bie@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 20 Mar 2019 07:35:41 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiqueue support with vhost kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320073537.sevyFYTFz6tyLEZL1G9wFfcbzyK7INl7psgLpBe8hco@z> On 3/12/19 8:13 AM, Tiwei Bie wrote: > The multiqueue support in virtio-user with vhost kernel backend > is broken when tap name isn't specified by users explicitly, > because the tap name returned by ioctl(TUNSETIFF) isn't saved > properly, and multiple tap interfaces will be created in this > case. Fix this by saving the dynamically allocated tap name > first before reusing the ifr structure. Besides, also make it > possible to support the format string in tap name (e.g. foo%d) > specified by users explicitly. > > Fixes: 791b43e08842 ("net/virtio-user: specify MAC of the tap") > Cc: stable@dpdk.org > > Reported-by: Stephen Hemminger > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Applied to dpdk-next-virtio/master branch. Thanks, Maxime