From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 16CCBA00E6 for ; Wed, 20 Mar 2019 08:36:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6ED92C39; Wed, 20 Mar 2019 08:36:10 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1F20C1DBD; Wed, 20 Mar 2019 08:36:09 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C141308429D; Wed, 20 Mar 2019 07:36:08 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A36DA5C297; Wed, 20 Mar 2019 07:36:06 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: tiwei.bie@intel.com, yinan.wang@intel.com, stable@dpdk.org References: <1550823230-16809-1-git-send-email-jiayu.hu@intel.com> <1552804712-9973-1-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 20 Mar 2019 08:36:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552804712-9973-1-git-send-email-jiayu.hu@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 20 Mar 2019 07:36:08 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320073604.mYwl2rlU4LvtJTXUbgCRvIbSrs9Qg4WyVxrWFK_mr_Q@z> On 3/17/19 7:38 AM, Jiayu Hu wrote: > The VIRTIO_RING_F_EVENT_IDX feature of split ring might > be broken, as the value of signalled_used is invalid > after live migration, start up and virtio driver reload. > This patch fixes it by using signalled_used_valid. > > In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX > implementation of split ring match kernel backend to suppress > more interrupts. > > Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppression") > Cc:stable@dpdk.org > > Signed-off-by: Jiayu Hu > --- > change in v2: > - fix virtio-net driver reload > > lib/librte_vhost/vhost.h | 12 ++++++++---- > lib/librte_vhost/vhost_user.c | 2 ++ > 2 files changed, 10 insertions(+), 4 deletions(-) Applied to dpdk-next-virtio/master branch. Thanks, Maxime