From: "Peng, Yuan" <yuan.peng@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key
Date: Wed, 20 Mar 2019 09:21:13 +0000 [thread overview]
Message-ID: <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> (raw)
Message-ID: <20190320092113._9EqVj3GwiGHRQkLg3MysxVRBwJvHbGSmca-3dKAdt8@z> (raw)
In-Reply-To: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
- Tested Branch: master
- Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
- OS: 4.13.9-300.fc27.x86_64
- GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Device Fortville [8086:1583]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 case1, 1 passed, 0 failed
- Case steps:
1. Bind the pf port to dpdk driver:
./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1
2. start testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
3. set an invalid RSS-key
testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key 67108863 / end
i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured
i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use default configuration
Flow rule #0 created
there is a device warning reported.
-----Original Message-----
From: Zhao1, Wei
Sent: Wednesday, March 20, 2019 11:31 AM
To: dev@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/i40e: add warning info when no perfect RSS key
There need a warning info when no perfect RSS key is config, so i40e will use default key.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
rss_conf.rss_key = (uint8_t *)rss_key_default;
rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
+ PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so
+use default configuration\n");
}
i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5
next prev parent reply other threads:[~2019-03-20 9:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 3:31 Wei Zhao
2019-03-20 3:31 ` Wei Zhao
2019-03-20 9:21 ` Peng, Yuan [this message]
2019-03-20 9:21 ` Peng, Yuan
2019-03-20 9:23 ` Zhao1, Wei
2019-03-20 9:23 ` Zhao1, Wei
2019-03-20 12:20 ` Kevin Traynor
2019-03-20 12:20 ` Kevin Traynor
2019-03-22 1:27 ` Zhao1, Wei
2019-03-22 1:27 ` Zhao1, Wei
2019-03-22 2:16 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-03-22 2:16 ` Wei Zhao
2019-03-22 3:06 ` Wei Zhao
2019-03-22 3:06 ` Wei Zhao
2019-03-22 13:30 ` Zhang, Qi Z
2019-03-22 13:30 ` Zhang, Qi Z
2019-03-26 8:35 ` [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid Wei Zhao
2019-03-26 8:35 ` Wei Zhao
2019-03-26 12:41 ` Zhang, Qi Z
2019-03-26 12:41 ` Zhang, Qi Z
2019-03-26 14:51 ` Ferruh Yigit
2019-03-26 14:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com \
--to=yuan.peng@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).