From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id E33201B203 for ; Wed, 20 Mar 2019 18:50:15 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id i17so2451682pfo.6 for ; Wed, 20 Mar 2019 10:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZL2m8sG28vkQV4tOxddIf0G4apXkpozUkqQyC0fZNfI=; b=qU2Q0z382NfjjJcmDtEhZQ63Pw2je6LDJObyRmSnvHICj2Ceh53tCmKiwuCRnaboZS 0aZUk8b6iDxkiuqgqOVmrlGQticAAwsTNbAEivi0bYD4mO7cq8MDWnpjRCeL0Qtqf26Q Znld5UfzNbsXQkXPegZ8ul4ykTB/Yhr4mWa7PIa8UCBxItaiq5gZroJ2A1F45dkQfdSa KJFeRrtCur0m2+X8XzMQivI8UFFNwc67g/jTJMr5h1F6PrPkXRrINIfp/S4tiUGXkGjL 97TWXdiOGH5YjNEjfVGIs+M03zGUvI1fMWizrYFQ+1LNQNFCrGLwb1hHj/1dyzJt8nh9 /yXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZL2m8sG28vkQV4tOxddIf0G4apXkpozUkqQyC0fZNfI=; b=JyLaWbBp82fQr+ITRwK6DWmmuffVYgxRCbWiB6KW53xZffc5EKGZzSFX7SpoR4Xu+p 35acf7yBTbQWK6SO16KAqNWIFmaHZw3Ffh51/YiR0vv57VhiYydEO+MgJhnrYzqOMey1 b5wyjFrYvS6upTUKpzHhlQpAYeSb6IoFfZ7VfqFw1GaUV2u6YXHyDQvqB6/Cqd/AX9Rn yKj5SNC2jSLYQHCajCyxa1U9AeIZOx0J0ih5dt0bKI21rExG4Ak8g8KQlt5XkTVXv8LP xWelY8ZrPZEBX8qjNk3XxQUIHaUecTZkS1fSMPAPDCM2bDH6XEY3qzstp4LhZ1Xr6jpg ok3w== X-Gm-Message-State: APjAAAVkmE+raPhLSPrY3J3Vf8ryZUdNGJep4sXOPEpRqJot6LX/TG0q rUMqDstPKL6oCUaQbUS3d308gw== X-Google-Smtp-Source: APXvYqz7vRJK7kn3cIeIsXnpRczVrJ6YELm1m9sHSwxYApNaKszZuFXZnor1iiGLWtqD81mjA2L2dg== X-Received: by 2002:a17:902:8c8b:: with SMTP id t11mr8995191plo.148.1553104214833; Wed, 20 Mar 2019 10:50:14 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k72sm6874072pfb.122.2019.03.20.10.50.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 10:50:13 -0700 (PDT) Date: Wed, 20 Mar 2019 10:50:09 -0700 From: Stephen Hemminger To: Tiwei Bie Cc: Kevin Traynor , Maxime Coquelin , Jens Freimann , zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20190320105009.27ef685c@shemminger-XPS-13-9360> In-Reply-To: <20190320044026.GA23715@dpdk-tbie.sh.intel.com> References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-6-tiwei.bie@intel.com> <20190319094432.iap4i7ffs6soukr7@jenstp.localdomain> <20190319100939.GA3839@dpdk-tbie.sh.intel.com> <20190319134751.ibgaalfravjm77lh@jenstp.localdomain> <1d05e311-c60b-cb1d-ff2b-974e01a0451b@redhat.com> <64884489-8cc7-7c3f-5b65-09f46112adb0@redhat.com> <20190320044026.GA23715@dpdk-tbie.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 17:50:16 -0000 On Wed, 20 Mar 2019 12:40:26 +0800 Tiwei Bie wrote: > > I agree the vq_ prefix is not needed and I think the code is more > > readable in general seeing the packed/split name when using the struct. > > > > Please also consider that cosmetic changes in multiple places likely > > mean backports will not apply cleanly to the stable branches anymore, so > > it does have a cost. > > Yeah, agree. prefixing structure elements is an old school BSD thing back from when compilers were not smart about namespaces for identifiers. Agree that it is no longer needed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 47B72A00E6 for ; Wed, 20 Mar 2019 18:50:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FB821B213; Wed, 20 Mar 2019 18:50:17 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id E33201B203 for ; Wed, 20 Mar 2019 18:50:15 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id i17so2451682pfo.6 for ; Wed, 20 Mar 2019 10:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZL2m8sG28vkQV4tOxddIf0G4apXkpozUkqQyC0fZNfI=; b=qU2Q0z382NfjjJcmDtEhZQ63Pw2je6LDJObyRmSnvHICj2Ceh53tCmKiwuCRnaboZS 0aZUk8b6iDxkiuqgqOVmrlGQticAAwsTNbAEivi0bYD4mO7cq8MDWnpjRCeL0Qtqf26Q Znld5UfzNbsXQkXPegZ8ul4ykTB/Yhr4mWa7PIa8UCBxItaiq5gZroJ2A1F45dkQfdSa KJFeRrtCur0m2+X8XzMQivI8UFFNwc67g/jTJMr5h1F6PrPkXRrINIfp/S4tiUGXkGjL 97TWXdiOGH5YjNEjfVGIs+M03zGUvI1fMWizrYFQ+1LNQNFCrGLwb1hHj/1dyzJt8nh9 /yXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZL2m8sG28vkQV4tOxddIf0G4apXkpozUkqQyC0fZNfI=; b=JyLaWbBp82fQr+ITRwK6DWmmuffVYgxRCbWiB6KW53xZffc5EKGZzSFX7SpoR4Xu+p 35acf7yBTbQWK6SO16KAqNWIFmaHZw3Ffh51/YiR0vv57VhiYydEO+MgJhnrYzqOMey1 b5wyjFrYvS6upTUKpzHhlQpAYeSb6IoFfZ7VfqFw1GaUV2u6YXHyDQvqB6/Cqd/AX9Rn yKj5SNC2jSLYQHCajCyxa1U9AeIZOx0J0ih5dt0bKI21rExG4Ak8g8KQlt5XkTVXv8LP xWelY8ZrPZEBX8qjNk3XxQUIHaUecTZkS1fSMPAPDCM2bDH6XEY3qzstp4LhZ1Xr6jpg ok3w== X-Gm-Message-State: APjAAAVkmE+raPhLSPrY3J3Vf8ryZUdNGJep4sXOPEpRqJot6LX/TG0q rUMqDstPKL6oCUaQbUS3d308gw== X-Google-Smtp-Source: APXvYqz7vRJK7kn3cIeIsXnpRczVrJ6YELm1m9sHSwxYApNaKszZuFXZnor1iiGLWtqD81mjA2L2dg== X-Received: by 2002:a17:902:8c8b:: with SMTP id t11mr8995191plo.148.1553104214833; Wed, 20 Mar 2019 10:50:14 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k72sm6874072pfb.122.2019.03.20.10.50.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 10:50:13 -0700 (PDT) Date: Wed, 20 Mar 2019 10:50:09 -0700 From: Stephen Hemminger To: Tiwei Bie Cc: Kevin Traynor , Maxime Coquelin , Jens Freimann , zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20190320105009.27ef685c@shemminger-XPS-13-9360> In-Reply-To: <20190320044026.GA23715@dpdk-tbie.sh.intel.com> References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-6-tiwei.bie@intel.com> <20190319094432.iap4i7ffs6soukr7@jenstp.localdomain> <20190319100939.GA3839@dpdk-tbie.sh.intel.com> <20190319134751.ibgaalfravjm77lh@jenstp.localdomain> <1d05e311-c60b-cb1d-ff2b-974e01a0451b@redhat.com> <64884489-8cc7-7c3f-5b65-09f46112adb0@redhat.com> <20190320044026.GA23715@dpdk-tbie.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320175009.XPINu7sIKpOFmbCd1nFfplyTJJx-zxyEWAY6IR-L6OA@z> On Wed, 20 Mar 2019 12:40:26 +0800 Tiwei Bie wrote: > > I agree the vq_ prefix is not needed and I think the code is more > > readable in general seeing the packed/split name when using the struct. > > > > Please also consider that cosmetic changes in multiple places likely > > mean backports will not apply cleanly to the stable branches anymore, so > > it does have a cost. > > Yeah, agree. prefixing structure elements is an old school BSD thing back from when compilers were not smart about namespaces for identifiers. Agree that it is no longer needed.