From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 52F27A00E6 for ; Wed, 20 Mar 2019 16:26:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C9581B11C; Wed, 20 Mar 2019 16:26:19 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C81B94F9A for ; Wed, 20 Mar 2019 16:26:17 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 08:26:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="153471133" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga002.fm.intel.com with ESMTP; 20 Mar 2019 08:26:15 -0700 Date: Wed, 20 Mar 2019 23:22:16 +0800 From: Ye Xiaolong To: David Marchand Cc: Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "olivier.matz@6wind.com" , "magnus.karlsson@intel.com" , "qi.z.zhang@intel.com" , "bjorn.topel@intel.com" Message-ID: <20190320152216.GB49599@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190319071256.26302-1-xiaolong.ye@intel.com> <20190319071256.26302-7-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320152216.ELEk2ovA1g9c_6Kho1cWUfmtx9mQqk2lamNllzNv8cI@z> On 03/20, David Marchand wrote: >On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < >jerinj@marvell.com> wrote: > >> On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: >> > When create rte_mempool, flags can be parsed from command line. >> > Now, it is possible for testpmd to create a af_xdp friendly >> > mempool (which enable zero copy). >> > >> > Signed-off-by: Qi Zhang >> > Signed-off-by: Xiaolong Ye >> > --- >> > app/test-pmd/parameters.c | 12 ++++++++++++ >> > app/test-pmd/testpmd.c | 17 ++++++++++------- >> > app/test-pmd/testpmd.h | 1 + >> > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ >> >> If I understand it correctly, The user needs to change all the >> application in order to avail zero copy feature of XDP. >> >> If so, >> >> How about creating wrapper mempool driver for xdp at drivers/mempool/? >> and mempool's best mempool feature to select the required mempool >> driver for XDP at runtime without changing the apps. >> >> see rte_mbuf_best_mempool_ops() >> see struct eth_dev_ops::pool_ops_supported >> > >Glab to read this, I was under the same impression :-) We plan to separate this in another patchset and may target for next release. Thanks, Xiaolong > > >-- >David Marchand