Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version library only

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Monday, March 4, 2019 2:58 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Trahe,
> Fiona <fiona.trahe@intel.com>
> Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version
> library only
> 
> As stated in 19.02 deprecation notice, this patch updates the
> aesni_mb PMD to remove the support of older Intel-ipsec-mb
> library version eariler than 0.52.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> 
> v2:
> - fixed incorrect version in documentation.
> 
>  doc/guides/cryptodevs/aesni_mb.rst                 |    8 +-
>  doc/guides/rel_notes/deprecation.rst               |    3 -
>  drivers/crypto/aesni_mb/Makefile                   |   21 +-
>  drivers/crypto/aesni_mb/aesni_mb_ops.h             |  302 -----
>  drivers/crypto/aesni_mb/meson.build                |   13 +-
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c  | 1313 ------------------
> --
>  .../crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c  |  745 -----------
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h |   37 -
>  8 files changed, 16 insertions(+), 2426 deletions(-)
>  delete mode 100644 drivers/crypto/aesni_mb/aesni_mb_ops.h
>  delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c
>  delete mode 100644
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c
> 
> diff --git a/doc/guides/cryptodevs/aesni_mb.rst
> b/doc/guides/cryptodevs/aesni_mb.rst
> index 47f2ecc2f..66c44e03a 100644
> --- a/doc/guides/cryptodevs/aesni_mb.rst
> +++ b/doc/guides/cryptodevs/aesni_mb.rst
> @@ -57,10 +57,7 @@ Limitations
> 
>  * Chained mbufs are not supported.
>  * Only in-place is currently supported (destination address is the same as
> source address).
> -* RTE_CRYPTO_AEAD_AES_GCM only works properly when the multi-buffer
> library is
> -  0.51.0 or newer.
> -* RTE_CRYPTO_HASH_AES_GMAC is supported by library version v0.51 or
> later.
> -* RTE_CRYPTO_HASH_SHA* is supported by library version v0.52 or later.
> +* Only support Intel multi buffer library version 0.52 or later.
> 

I'd say it is not needed to state this as a limitation.

> 
>  Installation
> @@ -92,7 +89,8 @@ and the Multi-Buffer library version supported by them:
>     17.05 - 17.08   0.45 - 0.48
>     17.11           0.47 - 0.48
>     18.02           0.48
> -   18.05+          0.49+
> +   18.05           0.49

Change to 18.05 - 19.02     0.49 - 0.52

> +   19.05+          0.52+
>     ==============  ============================
> 
>

Apart from this:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>