From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id C4ED61B51D for ; Thu, 21 Mar 2019 16:31:25 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id 8so4533610pfr.4 for ; Thu, 21 Mar 2019 08:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8Zzco6D14+i+lk5+EjXLrn3Hti8sk3yS8IX6dPrEqKw=; b=rrZni04EgLxfMqHAwDOt0K3vmuqsd1wt+U9R++mcQVuM1TzsqfK2685dJwPbw/megv OQ9MaHG0bB2dxqcQIL7G7r4ixgP166WXbr/YJm0mtVqrbOLxmTbAUOdLFjG6JqMJummu CUIT+FkKpHBnSiNBRcyZgnB9hr03YlvbbE8zMiwFpHt2ZXYQzyYrk9LdspNt1tt3uyrU LLt3MaqlnVy4gmOmjTDa0q1Hxmp8rhC4ykr3oQsfkIETrpzoHh2Hcdgy6uPadoFzqWZm ComStJm4s+DmGqDaRbd8bZ4eluiE2VdS5tWOSQdWqH+pFKlxCYyCuHYs96kVDCeFRCNr ouTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8Zzco6D14+i+lk5+EjXLrn3Hti8sk3yS8IX6dPrEqKw=; b=ow13IgI0gD4KJWUC7EZkBWYNJMOhMi3pGNb+zACaJgXW30cTKj7Cvy928pZIIm1F2j 1N4NF01q6sVeAZ+pDZInLiXBjrcQwCUDFdPQqwgOCkYZqNpWxtLdn0q90Pn27550un7p +1WA2p+qrrIjvX+QEyhsDHb0zth9sUD/zrOXAaouUDlflECrKb6LPGmxRdrsrrGO1ajz S3v7WmYQZaGZaLkIAV1LMxXbgtAJ48YkvRaSSoiiX1MvGj0e5OuplhmgmruBO6+aHQ0B 8xadMEeekcBWMTcqW9AZhdTjmq8WICQ8ElpF2j0T9bWtJtJCozHFRQFeV5R7yf4DG/zK MnNA== X-Gm-Message-State: APjAAAVLu/idb9X19LL75Izhg6FIcPbLUzx95aV7I0PnUcrJBIVusWy9 d0lTNRQPwZOjSguEyCBjd3JwUA== X-Google-Smtp-Source: APXvYqyvQk9x83e922cAfxYKiSW3Rb8Wx7wdzAIyI0scVo2W3D/tS/ZKifIZTua8baC5KBghYDS4Sw== X-Received: by 2002:aa7:8082:: with SMTP id v2mr3904480pff.164.1553182285041; Thu, 21 Mar 2019 08:31:25 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u4sm6626100pgn.12.2019.03.21.08.31.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 08:31:24 -0700 (PDT) Date: Thu, 21 Mar 2019 08:31:21 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190321083121.15e6dfb1@shemminger-XPS-13-9360> In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 15:31:26 -0000 On Thu, 21 Mar 2019 17:18:41 +0800 Xiaolong Ye wrote: > + if (strnlen(value, IFNAMSIZ) > IFNAMSIZ - 1) { > + RTE_LOG(ERR, AF_XDP, "Invalid name %s, should be less than " > + "%u bytes.\n", value, IFNAMSIZ) Please don't break error message strings across multiple source lines. It makes it harder to use tools like grep to find errors in source. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 90ABBA00E6 for ; Thu, 21 Mar 2019 16:31:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 662501B523; Thu, 21 Mar 2019 16:31:27 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id C4ED61B51D for ; Thu, 21 Mar 2019 16:31:25 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id 8so4533610pfr.4 for ; Thu, 21 Mar 2019 08:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8Zzco6D14+i+lk5+EjXLrn3Hti8sk3yS8IX6dPrEqKw=; b=rrZni04EgLxfMqHAwDOt0K3vmuqsd1wt+U9R++mcQVuM1TzsqfK2685dJwPbw/megv OQ9MaHG0bB2dxqcQIL7G7r4ixgP166WXbr/YJm0mtVqrbOLxmTbAUOdLFjG6JqMJummu CUIT+FkKpHBnSiNBRcyZgnB9hr03YlvbbE8zMiwFpHt2ZXYQzyYrk9LdspNt1tt3uyrU LLt3MaqlnVy4gmOmjTDa0q1Hxmp8rhC4ykr3oQsfkIETrpzoHh2Hcdgy6uPadoFzqWZm ComStJm4s+DmGqDaRbd8bZ4eluiE2VdS5tWOSQdWqH+pFKlxCYyCuHYs96kVDCeFRCNr ouTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8Zzco6D14+i+lk5+EjXLrn3Hti8sk3yS8IX6dPrEqKw=; b=ow13IgI0gD4KJWUC7EZkBWYNJMOhMi3pGNb+zACaJgXW30cTKj7Cvy928pZIIm1F2j 1N4NF01q6sVeAZ+pDZInLiXBjrcQwCUDFdPQqwgOCkYZqNpWxtLdn0q90Pn27550un7p +1WA2p+qrrIjvX+QEyhsDHb0zth9sUD/zrOXAaouUDlflECrKb6LPGmxRdrsrrGO1ajz S3v7WmYQZaGZaLkIAV1LMxXbgtAJ48YkvRaSSoiiX1MvGj0e5OuplhmgmruBO6+aHQ0B 8xadMEeekcBWMTcqW9AZhdTjmq8WICQ8ElpF2j0T9bWtJtJCozHFRQFeV5R7yf4DG/zK MnNA== X-Gm-Message-State: APjAAAVLu/idb9X19LL75Izhg6FIcPbLUzx95aV7I0PnUcrJBIVusWy9 d0lTNRQPwZOjSguEyCBjd3JwUA== X-Google-Smtp-Source: APXvYqyvQk9x83e922cAfxYKiSW3Rb8Wx7wdzAIyI0scVo2W3D/tS/ZKifIZTua8baC5KBghYDS4Sw== X-Received: by 2002:aa7:8082:: with SMTP id v2mr3904480pff.164.1553182285041; Thu, 21 Mar 2019 08:31:25 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u4sm6626100pgn.12.2019.03.21.08.31.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 08:31:24 -0700 (PDT) Date: Thu, 21 Mar 2019 08:31:21 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190321083121.15e6dfb1@shemminger-XPS-13-9360> In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321153121.4a4kb8SG1KKBJYElUEEEOv36s6Ja96eaksC68XtrXlc@z> On Thu, 21 Mar 2019 17:18:41 +0800 Xiaolong Ye wrote: > + if (strnlen(value, IFNAMSIZ) > IFNAMSIZ - 1) { > + RTE_LOG(ERR, AF_XDP, "Invalid name %s, should be less than " > + "%u bytes.\n", value, IFNAMSIZ) Please don't break error message strings across multiple source lines. It makes it harder to use tools like grep to find errors in source.