From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 51393A00E6
for <public@inbox.dpdk.org>; Thu, 21 Mar 2019 10:13:51 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6F7111B454;
Thu, 21 Mar 2019 10:13:50 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.101.70])
by dpdk.org (Postfix) with ESMTP id D51181B44E
for <dev@dpdk.org>; Thu, 21 Mar 2019 10:13:49 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30153374;
Thu, 21 Mar 2019 02:13:49 -0700 (PDT)
Received: from net-arm-thunderx2.shanghai.arm.com
(net-arm-thunderx2.shanghai.arm.com [10.169.40.112])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BA6703F71A;
Thu, 21 Mar 2019 02:13:47 -0700 (PDT)
From: Joyce Kong <joyce.kong@arm.com>
To: dev@dpdk.org
Cc: nd@arm.com, stephen@networkplumber.org, jerin.jacob@caviumnetworks.com,
konstantin.ananyev@intel.com, thomas@monjalon.net,
honnappa.nagarahalli@arm.com, gavin.hu@arm.com
Date: Thu, 21 Mar 2019 17:13:25 +0800
Message-Id: <1553159608-205213-1-git-send-email-joyce.kong@arm.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1547802943-18711-1-git-send-email-joyce.kong@arm.com>
References: <1547802943-18711-1-git-send-email-joyce.kong@arm.com>
Subject: [dpdk-dev] [PATCH v7 0/3] ticketlock: implement ticketlock and add
test case
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190321091325.Gii8uYcwY-hUrbFXFIhYuX0invl3k07sHSd2b9rXIsk@z>
v7:
1. Modify trylock to compare both current and next fields to gurantee the lock
being obtained only if tl->current==1(lock is free).
As within the trylock function, suppose next==curr=1, then this thread will
experience really long context switch, and next time it continues its
execution and tl->next wraps around to 1 again and tl_couurent==0(lock
held by another thread),this trylock will return a success, that means
two threads holding the lock. (Suggested by Konstantin Ananyev)
2. Let all archs use generic ticketlock implementation.
v6:
Add rte_ticketlock.h in lib/librte_eal/common/include/arch/arm/.
Sort header inside ticketlock files by alphabetical order.
v5:
Change the variants inside rte_ticket_lock from unint to uint16_t for binary
compatibility with the plain spin lock(suggested by Honnappa Nagarahalli)).
v4:
Change some assignment operation in recursive ticket lock to __atomic.
V3:
1.Update ticketlock intrduction(suggested by Honnappa Nagarahalli).
2.Change the implementation of rte_ticketlock_trylock to CAS(suggested by Honnappa Nagarahalli).
V2:
1.Update commit message(suggested by Jerin Jacob).
2.Add ticketlock test cases(suggested by Jerin Jacob).
V1:
Implement ticket lock to improve lock fairness and prdictability.
As shown on thundex-2 platform:
*** ticketlock_autotest with this patch ***
Core [0] count = 496
Core [1] count = 495
Core [2] count = 498
...
Core [209] count = 488
Core [210] count = 490
Core [211] count = 474
Joyce Kong (3):
eal/ticketlock: ticket based to improve fairness
eal/ticketlock: enable generic ticketlock on all arch
test/ticketlock: add ticket lock test case
MAINTAINERS | 5 +
app/test/Makefile | 1 +
app/test/autotest_data.py | 6 +
app/test/meson.build | 1 +
app/test/test_ticketlock.c | 311 +++++++++++++++++++++
doc/api/doxy-api-index.md | 1 +
lib/librte_eal/common/Makefile | 2 +-
.../common/include/arch/arm/rte_ticketlock.h | 22 ++
.../common/include/arch/ppc_64/rte_ticketlock.h | 18 ++
.../common/include/arch/x86/rte_ticketlock.h | 18 ++
.../common/include/generic/rte_ticketlock.h | 215 ++++++++++++++
lib/librte_eal/common/meson.build | 1 +
12 files changed, 600 insertions(+), 1 deletion(-)
create mode 100644 app/test/test_ticketlock.c
create mode 100644 lib/librte_eal/common/include/arch/arm/rte_ticketlock.h
create mode 100644 lib/librte_eal/common/include/arch/ppc_64/rte_ticketlock.h
create mode 100644 lib/librte_eal/common/include/arch/x86/rte_ticketlock.h
create mode 100644 lib/librte_eal/common/include/generic/rte_ticketlock.h
--
2.7.4